STM32N6: Add missing Kconfig #88786
Open
STM32N6: Add missing Kconfig #88786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
djiatsaf-st,
erwango,
FRASTM,
GeorgeCGV,
marwaiehm-st and
mathieuchopstm
mathieuchopstm
requested changes
Apr 18, 2025
gautierg-st
force-pushed
the
n6_various_fixes
branch
from
bcc052d to
83bcc91
Compare
mathieuchopstm
previously approved these changes
Apr 18, 2025
nordicjm
previously requested changes
Apr 22, 2025
soc/st/stm32/stm32n6x/CMakeLists.txt
Outdated
| @@ -24,6 +24,7 @@ if(SIGNING_TOOL_FIND STREQUAL SIGNING_TOOL_FIND-NOTFOUND) | |||
| Refer to board documentation for more information") | |||
| else() | |||
| set_property(GLOBAL APPEND PROPERTY extra_post_build_commands | |||
| COMMAND ${CMAKE_COMMAND} -E rm -f ${PROJECT_BINARY_DIR}/${CONFIG_KERNEL_BIN_NAME}.signed.bin | |||
There was a problem hiding this comment.
no to this, it does not work on windows and just looks bad, the original command should always update the file anyway so this is not even needed
There was a problem hiding this comment.
The problem is that the signing tool cannot delete or overwrite the previously generated file. So without this command, when recompiling, we get stuck at the signing command. The only solution is to abort, delete the signed file, and relaunch the compilation.
I agree that the signing tool should do that itself, but for now, as a workaround, it is our only choice.
There was a problem hiding this comment.
I've removed the offending commit. @nordicjm Can you take another look?
STM32N6 supports M-Profile Vector Extension (MVE) integer and floating-point instruction set. Signed-off-by: Guillaume Gautier <[email protected]>
gautierg-st
force-pushed
the
n6_various_fixes
branch
from
83bcc91 to
9616576
Compare
gautierg-st
changed the title
erwango
approved these changes
Apr 30, 2025
erwango
dismissed
nordicjm’s stale review
Dismissing as offending commit is gone.
FRASTM
approved these changes
Apr 30, 2025
mathieuchopstm
approved these changes
Apr 30, 2025
nordicjm
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some ARM Kconfig extension for STM32N6
and update the CMakeLists to remove the signed binary before generating a new one (preventingwest build autoto be stuck because the old binary can't be overwritten)