Skip to content

drivers: stepper: tmc_spi: remove print_status_byte #88795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

drivers: stepper: tmc_spi: remove print_status_byte #88795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions drivers/stepper/adi_tmc/adi_tmc_spi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,34 +4,10 @@
*/

#include <zephyr/sys/util.h>

#include "adi_tmc_spi.h"

#define BUFFER_SIZE 5U

#include <zephyr/logging/log.h>

LOG_MODULE_REGISTER(tmc_spi, CONFIG_SPI_LOG_LEVEL);

static void parse_tmc_spi_status(const uint8_t status_byte)
{
if ((status_byte & BIT_MASK(0)) != 0) {
LOG_WRN("spi dataframe: reset_flag detected");
}
if ((status_byte & BIT_MASK(1)) != 0) {
LOG_WRN("spi dataframe: driver_error(1) detected");
}
if ((status_byte & BIT_MASK(2)) != 0) {
LOG_WRN("spi dataframe: driver_error(2) detected");
}
}

static void print_tx_rx_buffer(const uint8_t *const tx_buffer, const uint8_t *const rx_buffer)
{
LOG_HEXDUMP_DBG(tx_buffer, BUFFER_SIZE, "TX: ");
LOG_HEXDUMP_DBG(rx_buffer, BUFFER_SIZE, "RX: ");
}

int tmc_spi_read_register(const struct spi_dt_spec *bus, const uint8_t read_address_mask,
const uint8_t register_address, uint32_t *data)
{
Expand Down Expand Up @@ -63,9 +39,6 @@ int tmc_spi_read_register(const struct spi_dt_spec *bus, const uint8_t read_addr
return status;
}

print_tx_rx_buffer(tx_buffer, rx_buffer);
parse_tmc_spi_status(rx_buffer[0]);

/** read the value from the address */
status = spi_transceive_dt(bus, &spi_buffer_array_tx, &spi_buffer_array_rx);
if (status < 0) {
Expand All @@ -75,8 +48,6 @@ int tmc_spi_read_register(const struct spi_dt_spec *bus, const uint8_t read_addr
*data = ((uint32_t)rx_buffer[1] << 24) + ((uint32_t)rx_buffer[2] << 16) +
((uint32_t)rx_buffer[3] << 8) + (uint32_t)rx_buffer[4];

print_tx_rx_buffer(tx_buffer, rx_buffer);
parse_tmc_spi_status(rx_buffer[0]);
return status;
}

Expand Down Expand Up @@ -111,8 +82,5 @@ int tmc_spi_write_register(const struct spi_dt_spec *bus, const uint8_t write_bi
return status;
}

print_tx_rx_buffer(tx_buffer, rx_buffer);
parse_tmc_spi_status(rx_buffer[0]);

return status;
}