openthread: Separate OpenThread Kconfigs from L2 layer #88799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: OpenThread
Release Notes
github-actions
bot
requested review from
canisLupus1313,
edmont,
fabiobaltieri,
jukkar,
kartben,
kkasperczyk-no,
maciejbaczmanski,
mariuszpos,
pdgendt,
rlubos,
ssharks and
tbursztyka
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- doc/releases/migration-guide-4.2.rst: Language not supported
- doc/releases/release-notes-4.2.rst: Language not supported
- modules/openthread/Kconfig: Language not supported
- subsys/net/l2/CMakeLists.txt: Language not supported
- subsys/net/l2/openthread/Kconfig: Language not supported
jukkar
previously approved these changes
Apr 19, 2025
kkasperczyk-no
previously approved these changes
Apr 22, 2025
ArekBalysNordic
dismissed stale reviews from kkasperczyk-no and jukkar
via
c41d9b0
ArekBalysNordic
force-pushed
the
separate_ot_configs_from_l2
branch
from
26de5bc to
c41d9b0
Compare
kkasperczyk-no
previously approved these changes
Apr 22, 2025
LuDuda
approved these changes
Apr 22, 2025
Moved OpenThread-related Kconfigs from L2 layer to modules/openthread. All of those configs were not strictly related to the L2 layer, so they fits better to OpenThread module. This operation allows using OpenThread Kconfigs even if L2 layer is disabled. Enabling NET_L2_OPENTHREAD also configures those configs by selecting the OPENTHREAD kconfig, so there is no change regarding backwards compatibility. The only change is that the Kconfigs related to Thread were moved to the modules space, so their location in the menuconfig also changed. Once it is done, a choice for setting different L2 implementations seems to be redundant. Signed-off-by: Arkadiusz Balys <[email protected]>
Add an entry to the release notes and migration guide regarding moving OpenThread-related Kconfig options from subsys/net/l2/openthred/Kconfig to modules/openthread/Kconfig. Signed-off-by: Arkadiusz Balys <[email protected]>
ArekBalysNordic
force-pushed
the
separate_ot_configs_from_l2
branch
from
c41d9b0 to
53ddc2f
Compare
rlubos
approved these changes
Apr 23, 2025
jukkar
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved OpenThread-related Kconfigs from L2 layer to modules/openthread. All of those configs were not strictly related
to the L2 layer, so they fits better to OpenThread module.
This operation allows using OpenThread Kconfigs even if L2 layer is disabled.
Enabling NET_L2_OPENTHREAD also configures those configs by selecting the OPENTHREAD kconfig, so there is no change regarding backwards compatibility. The only change is that the Kconfigs related to Thread were moved to the modules
space, so their location in the menuconfig also changed.
Once it is done, a choice for setting different L2 implementations seems to be redundant.