cmake: ensure -fstack-protector-explicit is applied to C++ targets #88833
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo in the top-level CMakeLists.txt prevented C++ targets from receiving -fstack-protector-explicit when CONFIG_STACK_CANARIES_EXPLICIT=y. Signed-off-by: Mirai SHINJO <[email protected]>
github-actions
bot
added
size: XS
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
pdgendt
approved these changes
Apr 20, 2025
nordicjm
approved these changes
Apr 22, 2025
nordicjm
added
the
Trivial
tejlmand
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake: ensure -fstack-protector-explicit is applied to C++ targets
A typo in the top-level CMakeLists.txt prevented C++ targets from
receiving -fstack-protector-explicit when CONFIG_STACK_CANARIES_EXPLICIT=y.
Signed-off-by: Mirai SHINJO [email protected]