drivers: display: sdl: Ensure task thread is run once on init #88886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Display
size: XS
github-actions
bot
requested review from
danieldegrasse,
jfischer-no and
VynDragon
JarmouniA
approved these changes
Apr 22, 2025
faxe1008
force-pushed
the
fix-sdl-display-threading
branch
2 times, most recently
from
e5f5630 to
5e1318d
Compare
pdgendt
reviewed
Apr 23, 2025
Adds taking of the task semaphore after creating the display thread to ensure that the thread is run once, executing the SDL init. Adjust the threads priority to match the main thread. Signed-off-by: Fabian Blatz <[email protected]>
faxe1008
force-pushed
the
fix-sdl-display-threading
branch
from
5e1318d to
df2909c
Compare
pdgendt
approved these changes
Apr 23, 2025
pdgendt
changed the title
|
Looks good to me, if that fixes #88818 |
JarmouniA
approved these changes
Apr 23, 2025
VynDragon
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a yield after creating the display thread to ensure that the thread is run once, executing the SDL init.
Resolves #88818