Skip to content

bluetooth: samples: mtu_update: peripheral: Add NULL check #88889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sayooj-atmosic
Copy link
Contributor

Add NULL check for connection context, and only send the notification if connection is established.

Add NULL check for connection context, and only send the
notification if connection is established.

Signed-off-by: Sayooj K Karun <[email protected]>
Copy link

Hello @sayooj-atmosic, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although the sample seems pretty naively implemented. It could be further improved by using e.g. a semaphore to not do any looping until it's actually connected.

@jhedberg jhedberg changed the title bluetooth: mtu_update: peripheral: Add NULL check bluetooth: samples: mtu_update: peripheral: Add NULL check Apr 22, 2025
Copy link
Collaborator

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is OK, although I think it makes more sense to not print anything when not connected

@kartben kartben merged commit bf104d4 into zephyrproject-rtos:main Apr 24, 2025
25 checks passed
Copy link

Hi @sayooj-atmosic!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth area: Samples Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants