Skip to content

Bluetooth: BAP: Update encrypt_state when BIG synced after bad code #88891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Bluetooth: BAP: Update encrypt_state when BIG synced after bad code #88891

merged 1 commit into from
Apr 24, 2025

Conversation

mefromac
Copy link

Fixes #88461

@github-actions GitHub Actions
Copy link

Hello @mefromac, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Thalley
Thalley requested changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK (needs a small formatting fix), but the commit message needs to be more descriptive and not refer to a Github issue.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines

@mefromac mefromac force-pushed the fix-scan-delegator-keeps-reporting-bad-code-after-big-sync branch from add4eeb to 9cee0da Compare April 22, 2025 10:40
Bluetooth: BAP: Update encrypt_state when BIG synced after bad code
7616520 
- When encrypt_state in a receive state of the scan delegator is
  BT_BAP_BIG_ENC_STATE_BAD_CODE, make sure that on synchronization
  encrypt_state is updated to BT_BAP_BIG_ENC_STATE_DEC, as this
  implies that a correct code was provided, so that the broadcast
  assistant is not asked for a correct code any longer.

Signed-off-by: Max Emde <[email protected]>
@mefromac mefromac force-pushed the fix-scan-delegator-keeps-reporting-bad-code-after-big-sync branch from 9cee0da to 7616520 Compare April 22, 2025 10:41
@Thalley Thalley requested a review from Copilot April 22, 2025 10:45
Copilot
Copilot AI reviewed Apr 22, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #88461 by ensuring that the encryption state is properly updated after a BIG sync when a bad code is encountered.

  • Updated condition in update_recv_state_big_synced() to handle BT_BAP_BIG_ENC_STATE_BAD_CODE
  • Adjusted encryption state assignment based on the new condition

pin-zephyr
pin-zephyr approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@pin-zephyr pin-zephyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kartben kartben merged commit e04d828 into zephyrproject-rtos:main Apr 24, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Bluetooth LE Audio Apr 24, 2025
@github-actions GitHub Actions
Copy link

Hi @mefromac!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@larsgk larsgk larsgk approved these changes

@Thalley Thalley Thalley approved these changes

@pin-zephyr pin-zephyr pin-zephyr approved these changes

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@babrsn babrsn Awaiting requested review from babrsn

@Casper-Bonde-Bose Casper-Bonde-Bose Awaiting requested review from Casper-Bonde-Bose

@fredrikdanebjer fredrikdanebjer Awaiting requested review from fredrikdanebjer

@jhedberg jhedberg Awaiting requested review from jhedberg

@jthm-ot jthm-ot Awaiting requested review from jthm-ot

@MariuszSkamra MariuszSkamra Awaiting requested review from MariuszSkamra

@niym-ot niym-ot Awaiting requested review from niym-ot

@sjanc sjanc Awaiting requested review from sjanc

Assignees

@Thalley Thalley

Labels
area: Bluetooth Audio area: Bluetooth
Projects
Bluetooth LE Audio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scan delegator keeps reporting bad code to broadcast assistant after BIG is synchronized
5 participants
@mefromac @larsgk @Thalley @pin-zephyr @kartben