Apni2/tmc51xx log progress #88903
Merged
Apni2/tmc51xx log progress #88903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri,
faxe1008,
galak,
jbehrensnx,
jilaypandya,
MaureenHelm,
microbuilder,
ozersa,
ttmut and
yasinustunerg
apni2
force-pushed
the
apni2/tmc51xx_log_progress
branch
2 times, most recently
from
3d3ab02 to
4c3212c
Compare
jilaypandya
reviewed
Apr 23, 2025
apni2
force-pushed
the
apni2/tmc51xx_log_progress
branch
3 times, most recently
from
dda39cc to
d432486
Compare
jilaypandya
approved these changes
Apr 23, 2025
apni2
force-pushed
the
apni2/tmc51xx_log_progress
branch
from
d432486 to
1f5571c
Compare
Use rampstat_work_reschedule() and read_vactual(). Only log actual velocity when not 0. Update log_stallguard() output. Signed-off-by: Anders Nielsen <[email protected]>
Replace stall guard retry error log on EAGAIN with enable/disable info log. Log position, sg result and sg status on each rampstat_work_handler() call. Treat only negative return values from tmc_spi_write_register() and tmc_spi_read_register() as an error. Only log actual velocity when not 0. Use helper functions rampstat_work_reschedule() and read_vactual(). Signed-off-by: Anders Nielsen <[email protected]>
apni2
force-pushed
the
apni2/tmc51xx_log_progress
branch
from
1f5571c to
508e7c9
Compare
I have reworked the commit messages. |
MaureenHelm
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #88045 for tmc51xx
and some minor changes regarding logging in tmc50xx.
Replace stall guard retry error log on EAGAIN with enable/disable info log.
Log position, sg result and sg status on each rampstat_work_handler() call.
Treat only negative return values from tmc_spi_write_register() and
tmc_spi_read_register() as an error. Only log actual velocity when not 0.