Bluetooth: Controller: Fix missing window widening in ull_periph_setup #88906
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No window widening was applied to conn_offset_us causing the initial ticker_cb to get called slightly too late Apply window_widening_periodic_us to conn_offset_us, since this is the worst-case window widening (win_offset is not allowed to be larger than a connection interval) and is applied in the LLL window size already Fixes EBQ failure in LL/TIM/PER/BV-02-C Signed-off-by: Troels Nilsson <[email protected]>
github-actions
bot
added
size: XS
github-actions
bot
requested review from
carlescufi,
cvinayak,
erbr-ot,
thoh-ot and
wopu-ot
erbr-ot
approved these changes
Apr 23, 2025
cvinayak
requested changes
Apr 24, 2025
| @@ -418,6 +418,7 @@ void ull_periph_setup(struct node_rx_pdu *rx, struct node_rx_ftr *ftr, | |||
| conn_offset_us -= EVENT_TICKER_RES_MARGIN_US; | |||
| conn_offset_us -= EVENT_JITTER_US; | |||
| conn_offset_us -= ready_delay_us; | |||
| conn_offset_us -= lll->periph.window_widening_periodic_us; | |||
There was a problem hiding this comment.
Should it be something like below?
Suggested change
| conn_offset_us -= lll->periph.window_widening_periodic_us; | |
| conn_offset_us -= | |
| DIV_ROUND_UP(((lll_clock_ppm_local_get() + | |
| lll_clock_ppm_get(conn->periph.sca)) * | |
| (win_offset * CONN_INT_UNIT_US + win_delay_us)), USEC_PER_SEC); |
There was a problem hiding this comment.
Yes that would be the correct value to use; However, LLL does not know that and will apply window_widening_periodic_us anyway, so I thought we may as well use that value here as well. Adding another value for LLL to use seems overkill for this one case, although that would be the completely correct approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No window widening was applied to conn_offset_us causing the initial ticker_cb to get called slightly too late
Apply window_widening_periodic_us to conn_offset_us, since this is the worst-case window widening (win_offset is not allowed to be larger than a connection interval) and is applied in the LLL window size already
Fixes EBQ failure in LL/TIM/PER/BV-02-C