Skip to content

ish build: add new manifest v1.1 support #88922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lifenggitacc
Copy link
Contributor

ISH manifest v1.1 applies to ISH 5.8.
Add support for new ISH 5.8 manifest structure This patch introduces conditional logic to check the ISH version during the build process. If the version is 5.8, the build system will apply the new manifest structure. This ensures compatibility with the updated ISH firmware requirements and maintains backward compatibility with previous versions.
Tested with ISH version 5.8 to on PTL RVP platform and 5.4 on TWL Trulo platform.

@github-actions github-actions bot added the platform: Intel ISH Intel Corporation, Integrated Sensor Hub label Apr 22, 2025
ISH manifest v1.1 applies to ISH 5.8.

Signed-off-by: Li Feng <[email protected]>
@teburd
Copy link
Collaborator

teburd commented Apr 22, 2025

Hi Li! Please don't close and reopen pull requests, instead rebase and force push as needed to get CI passing and address comments

@lifenggitacc
Copy link
Contributor Author

Sorry, the PR check complains I tried to merge latest change to my branch, I should do the rebase. I couldn't figure out how fix that. so gave up my previous PR and opened a new one.

@teburd
Copy link
Collaborator

teburd commented Apr 22, 2025

Sorry, the PR check complains I tried to merge latest change to my branch, I should do the rebase. I couldn't figure out how fix that. so gave up my previous PR and opened a new one.

No worries, reach out if you run into something again

@lifenggitacc
Copy link
Contributor Author

I have tested the script on PTL (ISH 5.8) and it works correctly. Final image we need to use MEU to add metadata but that's next step. And also with this PR introduced, I tested old version ISH like TWL platform, and it works fine.
Please help review and get merge done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Intel ISH Intel Corporation, Integrated Sensor Hub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants