Skip to content

board: raytac: Add support for raytac_mdbt50q_cx_40_dongle #88926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RaytacStanley
Copy link
Contributor

Add support for Raytac's new TYPE-C dongle.

  • Nordic nRF52840 SoC Solution Dongle
  • Type-C USB
  • 1MB Flash Memory / 256kB RAM
  • 1 x Switch and max. 2 x LED

@RaytacStanley RaytacStanley force-pushed the add_new_mdbt50q_cx_40_dongle branch from d33d4fd to 129b80f Compare April 23, 2025 03:35
# Enable hardware stack protection
CONFIG_HW_STACK_PROTECTION=y

# enable GPIO
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# enable GPIO
# Enable GPIO

@JarmouniA JarmouniA added the platform: nRF Nordic nRFx label Apr 23, 2025
@RaytacStanley
Copy link
Contributor Author

@JarmouniA Thanks for the feedback! I will make the changes as soon as possible.

@RaytacStanley RaytacStanley force-pushed the add_new_mdbt50q_cx_40_dongle branch 2 times, most recently from 987a896 to ab38585 Compare April 24, 2025 02:03
Comment on lines 16 to 18
config BOARD_SERIAL_BACKEND_CDC_ACM
bool "USB CDC"
default y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is based on an old version of zephyr, please use the current nrf52840dongle and create this. Also apply changes from https://github.com/zephyrproject-rtos/zephyr/pull/89017/files

Comment on lines +45 to +46
SYS_INIT(board_raytac_mdbt50q_cx_40_dongle_nrf52840_init, PRE_KERNEL_1,
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use board hook

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

Comment on lines +44 to +45
The ``raytac_mdbt50q_cx_40_dongle/nrf52840`` board configuration supports the following
hardware features:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use hw directive

@RaytacStanley RaytacStanley force-pushed the add_new_mdbt50q_cx_40_dongle branch from ab38585 to bc2b658 Compare April 25, 2025 08:50
@RaytacStanley
Copy link
Contributor Author

@nordicjm Thanks for your feedback. I have modified it and uploaded the updated version.

Add support for Raytac's new TYPE-C dongle.

Signed-off-by: Stanley Huang <[email protected]>
@RaytacStanley RaytacStanley force-pushed the add_new_mdbt50q_cx_40_dongle branch from bc2b658 to 9d91411 Compare April 25, 2025 09:31
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix marked issues from previous review that have not been addressed


static int board_raytac_mdbt50q_cx_40_dongle_nrf52840_init(void)
{

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

static int board_raytac_mdbt50q_cx_40_dongle_nrf52840_init(void)
{

/* if the nrf52840dongle_nrf52840 board is powered from USB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*If, and this text doesn't make sense since this refers to a different board

Comment on lines +45 to +46
SYS_INIT(board_raytac_mdbt50q_cx_40_dongle_nrf52840_init, PRE_KERNEL_1,
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants