-
Notifications
You must be signed in to change notification settings - Fork 7.3k
board: raytac: Add support for raytac_mdbt50q_cx_40_dongle #88926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
board: raytac: Add support for raytac_mdbt50q_cx_40_dongle #88926
Conversation
d33d4fd
to
129b80f
Compare
# Enable hardware stack protection | ||
CONFIG_HW_STACK_PROTECTION=y | ||
|
||
# enable GPIO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# enable GPIO | |
# Enable GPIO |
boards/raytac/mdbt50q_cx_40_dongle/raytac_mdbt50q_cx_40_dongle_nrf52840.yaml
Outdated
Show resolved
Hide resolved
@JarmouniA Thanks for the feedback! I will make the changes as soon as possible. |
987a896
to
ab38585
Compare
config BOARD_SERIAL_BACKEND_CDC_ACM | ||
bool "USB CDC" | ||
default y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is based on an old version of zephyr, please use the current nrf52840dongle and create this. Also apply changes from https://github.com/zephyrproject-rtos/zephyr/pull/89017/files
SYS_INIT(board_raytac_mdbt50q_cx_40_dongle_nrf52840_init, PRE_KERNEL_1, | ||
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use board hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed
The ``raytac_mdbt50q_cx_40_dongle/nrf52840`` board configuration supports the following | ||
hardware features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use hw directive
ab38585
to
bc2b658
Compare
@nordicjm Thanks for your feedback. I have modified it and uploaded the updated version. |
Add support for Raytac's new TYPE-C dongle. Signed-off-by: Stanley Huang <[email protected]>
bc2b658
to
9d91411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix marked issues from previous review that have not been addressed
|
||
static int board_raytac_mdbt50q_cx_40_dongle_nrf52840_init(void) | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static int board_raytac_mdbt50q_cx_40_dongle_nrf52840_init(void) | ||
{ | ||
|
||
/* if the nrf52840dongle_nrf52840 board is powered from USB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*If, and this text doesn't make sense since this refers to a different board
SYS_INIT(board_raytac_mdbt50q_cx_40_dongle_nrf52840_init, PRE_KERNEL_1, | ||
CONFIG_KERNEL_INIT_PRIORITY_DEFAULT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed
Add support for Raytac's new TYPE-C dongle.