drivers: firmware: Add support for IRONside calls #88937
+401
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: IPC
github-actions
bot
requested review from
anangl,
arnopo,
carlocaione,
doki-nordic,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
57300
force-pushed
the
nrf-ironside-call
branch
from
bd7466b to
aaaf30f
Compare
SebastianBoe
requested changes
Apr 23, 2025
soc/nordic/common/ironside/call.c
Outdated
Comment on lines
94
to
95
| alloc_buf_bit = LSB_GET(avail_buf_bits); | ||
| } while (!k_event_clear(&alloc_evts, alloc_buf_bit)); |
There was a problem hiding this comment.
Suggested change
| alloc_buf_bit = LSB_GET(avail_buf_bits); | |
| } while (!k_event_clear(&alloc_evts, alloc_buf_bit)); | |
| alloc_buf_bit = LSB_GET(avail_buf_bits); | |
| bool event_was_taken_by_another_thread = 0 == k_event_clear(&alloc_evts, alloc_buf_bit); | |
| } while (event_was_taken_by_another_thread); |
Maybe make it more clear what this while loop is for.
hakonfam
reviewed
Apr 23, 2025
soc/nordic/common/ironside/Kconfig
Outdated
|
|
||
| config NRF_IRONSIDE_CALL_INIT_PRIORITY | ||
| int "IRONside calls' initialization priority" | ||
| default 47 |
There was a problem hiding this comment.
Should we have a rationale here? Even if the rationale is that its a random value and we don't have a rationale.
carlescufi
requested changes
Apr 24, 2025
IRONside calls are remote procedure calls which comprise the runtime interface of Nordic IRONside SE. They are realized using a simple IPC mechanism. A local domain (client) issues requests to the server by exchanging data in shared memory, which is divided into evenly sized buffers. The client selects a buffer, writes a request into it, and sends it to the server. The server processes that request and writes a response into the same buffer before returning it to the client. This patch adds the initial client-side implementation on top of MBOX. It features cache management and a blocking alloc/dispatch/release API for synchronous, zero-copy transfers. A new devicetree binding is added to support this implementation. It is patterned after the `zephyr,ipc-*` bindings, where each node associates a pair of mailboxes and a shared memory region. Signed-off-by: Grzegorz Swiderski <[email protected]>
Define `ipc_conf_iron.dtsi` and `memory_map_iron.dtsi`. In the future,
they will be merged with the base `ipc_conf.dtsi` and `memory_map.dtsi`
respectively. For now, they are used to replace a few devicetree nodes
when building for `nrf54h20dk/nrf54h20/*/iron` board targets.
Additional changes are included:
* The IPC configuration includes new "nordic,ipc-ironside" nodes.
* The memory map includes a new RAM20 layout. Its subregions are
placed under the `/reserved-memory` node like before.
* The MRAM partitions are moved to the common memory map, while the
MCUboot-specific node labels are applied in `cpuapp.dts`.
Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
force-pushed
the
nrf-ironside-call
branch
from
aaaf30f to
f7449de
Compare
57300
changed the title
Thanks for the tip! I think we should have all of our interfaces there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRONside calls are remote procedure calls which comprise the runtime interface of Nordic IRONside SE. They are realized using a simple IPC mechanism.