sys: ring_buffer: fix possible ring_buf_put_claim() wrong size #88961
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
andyross,
dcpleung,
nashif and
peter-mitsis
maass-hamburg
approved these changes
Apr 23, 2025
maass-hamburg
requested changes
Apr 23, 2025
- The issue is caused by the MIN() macro, which expands to (a)<(b)?(a):(b), where ring_buf_space_get()/ring_buf_size_get() is used as 'b' and is evaluated twice. The issue occurs when the (a)<(b) condition evaluates such that (b) is selected, but the value of (b) changes between evaluations, resulting in a possibly larger value than (a). - Fixes the potential incorrect behavior by storing the result of ring_buf_space_get()/ring_buf_size_get() in a variable before using it in the MIN macro. Signed-off-by: Andrej Butok <[email protected]>
butok
force-pushed
the
fix_ring_buf_put_claim_space
branch
from
b45f96f to
5d05369
Compare
maass-hamburg
approved these changes
Apr 23, 2025
The requested ring_buf_get_claim() fix has been added. |
nashif
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is used as 'b' and is evaluated twice. The issue occurs when the (a)<(b) condition evaluates such that (b) is selected,
but the value of (b) changes between evaluations, resulting in a possibly larger value than (a).