Allow IPv6 deprecated address selection #88976
Merged
+119
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
pdgendt,
rlubos,
ssharks and
tbursztyka
rlubos
reviewed
Apr 23, 2025
jukkar
force-pushed
the
fix/allow-ipv6-deprecated-address-selection
branch
from
21eb2e5 to
b63f6b9
Compare
|
Changed the address selection such a way that we allow deprecated address to be selected if it is a better match than the preferred one. |
rlubos
previously approved these changes
Apr 24, 2025
pdgendt
previously approved these changes
Apr 24, 2025
This adjust the IPv6 source address selection so that it is possible to select deprecated IPv6 address if no better preferred address is found. From RFC 6724 chapter 5: Rule 3: Avoid deprecated addresses. If one of the two source addresses is "preferred" and one of them is "deprecated" (in the RFC 4862 sense), then prefer the one that is "preferred". Rule 8: Use longest matching prefix. If CommonPrefixLen(SA, D) > CommonPrefixLen(SB, D), then prefer SA. Similarly, if CommonPrefixLen(SB, D) > CommonPrefixLen(SA, D), then prefer SB. So the fix allows deprecated address to be selected if it is a better match than the preferred one. The reasoning here is that an address with a longer matching prefix is generally considered topologically closer to the destination. Using such a source address can lead to more efficient routing, as it's more likely that the source and destination are within the same network segment or a closely related one. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure deprecated address is selected if no other address is available. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
force-pushed
the
fix/allow-ipv6-deprecated-address-selection
branch
from
b63f6b9 to
31c744c
Compare
|
rlubos
approved these changes
Apr 24, 2025
pdgendt
approved these changes
Apr 24, 2025
Damian-Nordic
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjust the IPv6 source address selection so that it is possible to select deprecated IPv6 address if no preferred address is found.
From RFC 6724 chapter 5:
If we never select deprecated address, then it is possible that we found no suitable address even if a deprecated address would be available.