Bluetooth: Classic: L2CAP: Fix the FCS incorrect issue #88995
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FCS flag of TX direction is not set correctly if the FCS flag of RX direction is set. The issue could be found with following steps, Step 1, Local sends configuration request with ERET mode and FCS omitted. Step 2, Peer replies the configuration response without any errors. Step 3, Peer sends configuration request with ERET mode and NO FCS. Step 4, Local replies the configuration response without any errors. The FCS flag of TX is cleared incorrectly. The FCS should be enabled if any one side enables the FCS. Signed-off-by: Lyle Zhu <[email protected]>
github-actions
bot
added
area: Bluetooth Classic
github-actions
bot
requested review from
gzh-terry,
jhedberg,
makeshi and
MarkWangChinese
makeshi
approved these changes
Apr 25, 2025
jhedberg
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FCS flag of TX direction is not set correctly if the FCS flag of RX direction is set. The issue could be found with following steps, Step 1, Local sends configuration request with ERET mode and FCS omitted.
Step 2, Peer replies the configuration response without any errors. Step 3, Peer sends configuration request with ERET mode and NO FCS. Step 4, Local replies the configuration response without any errors.
The FCS flag of TX is cleared incorrectly.
The FCS should be enabled if any one side enables the FCS.