drivers: fuelgauge: Add Onsemi LC709203F driver #89000

DBS06 · 2025-04-24T06:27:11Z

Add driver for the Onsemi LC709203F fuel gauge

Copilot

Pull Request Overview

This PR adds an Onsemi LC709203F fuel gauge driver along with samples, DTS binding, header updates, and an emulator implementation.

Introduces main sample application to demonstrate fuel gauge usage.
Updates fuel gauge header definitions and DTS binding to support new properties.
Provides an emulator implementation for testing.

Reviewed Changes

Copilot reviewed 13 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
samples/fuel_gauge/lc709203f/src/main.c	Implements sample app; contains a redundant dev check.
samples/fuel_gauge/lc709203f/sample.yaml	Provides sample configuration for the fuel gauge.
include/zephyr/drivers/fuel_gauge.h	Adds new fuel gauge properties.
dts/bindings/fuel-gauge/onnn,lc709203f.yaml	Adds DTS binding for the LC709203F fuel gauge.
drivers/fuel_gauge/lc709203f/lc709203f.h	Declares registers and APIs for the new driver.
drivers/fuel_gauge/lc709203f/emul_lc709203f.c	Implements an emulator for the LC709203F fuel gauge.

Files not reviewed (14)

boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2.rst: Language not supported
boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2_tft.rst: Language not supported
boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2_tft_reverse.rst: Language not supported
drivers/fuel_gauge/CMakeLists.txt: Language not supported
drivers/fuel_gauge/Kconfig: Language not supported
drivers/fuel_gauge/lc709203f/CMakeLists.txt: Language not supported
drivers/fuel_gauge/lc709203f/Kconfig: Language not supported
samples/fuel_gauge/lc709203f/CMakeLists.txt: Language not supported
samples/fuel_gauge/lc709203f/README.rst: Language not supported
samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2.conf: Language not supported
samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2.overlay: Language not supported
samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2_tft.conf: Language not supported
samples/fuel_gauge/lc709203f/boards/adafruit_feather_esp32s2_tft.overlay: Language not supported
samples/fuel_gauge/lc709203f/prj.conf: Language not supported

samples/fuel_gauge/lc709203f/src/main.c

kartben

Some early feedback

dts/bindings/fuel-gauge/onnn,lc709203f.yaml

samples/fuel_gauge/lc709203f/README.rst

boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2.rst

kartben

Also please separate in multiple commits as it is doing more than just adding a new driver (i.e. adding new fuel gauge property typed)

drivers/fuel_gauge/lc709203f/emul_lc709203f.c

DBS06 · 2025-04-24T08:01:59Z

Also please separate in multiple commits as it is doing more than just adding a new driver (i.e. adding new fuel gauge property typed

I will split the commits asap

DBS06 · 2025-04-24T08:02:24Z

Some early feedback

Thanks a lot for this fast reply!

DBS06 · 2025-04-24T12:18:16Z

Also please separate in multiple commits as it is doing more than just adding a new driver (i.e. adding new fuel gauge property typed)

I split up the commit into multiple commits in a way which I think makes sense

DBS06 · 2025-04-24T12:42:53Z

overview which is still missing or needs/should/wished to be changed

Made changes suggested by Copilot Review
Made changes suggested by kartbens early Review
Change CRC calculation to Zephyr CRC
Add explanation for dts/bindings default values
Split up the commits
Add most basic fuelgauge sample
Adapt Docu for Adafruit_ESP32S2_feather boards
Extend fuelgauge sample as discussed here: drivers: fuelgauge: Add Onsemi LC709203F driver #89000 (comment)

DBS06 · 2025-04-29T11:58:28Z

@kartben @aaronemassey @teburd I have one questiong regarding the doc/hardware/peripherals/fuel_gauge.rst
Imho I think this doc-file is partially outdated. Should I update it? Will the maintainers do it?
I think I am already doing a lot of changes with the PR and to update this file is somehow part of the job.. If wished I could also open a new PR for this, but I think this is not necessary.

teburd · 2025-04-29T13:10:06Z

@kartben @aaronemassey @teburd I have one questiong regarding the doc/hardware/peripherals/fuel_gauge.rst Imho I think this doc-file is partially outdated. Should I update it? Will the maintainers do it? I think I am already doing a lot of changes with the PR and to update this file is somehow part of the job.. If wished I could also open a new PR for this, but I think this is not necessary.

If you find missing/out of date docs then yes please send a separate PR updating them.

teburd · 2025-04-29T13:13:01Z

Please review your commits and messages. The very first commit has added properties but the commit title is "drivers: fuelgauge: Add Onsemi LC709203F driver". This should be more like...

fuelgauge: Add additional properties

Adds properties for charge and voltage alarms

Signed-off-by: ...

This commit should have no formatting changes and only the changes needed to add the attributes. Basically the commits need to be cleaned up before I'll take a look again

teburd

Most of this looks really nice, please fix the commit message titles and messages, ensure format changes are separate, +1 from me on doing so

tests/drivers/fuel_gauge/lc709203f/CMakeLists.txt

DBS06 · 2025-04-29T19:47:56Z

Most of this looks really nice, please fix the commit message titles and messages, ensure format changes are separate, +1 from me on doing so

Thanks a lot for your feedback, I really appreciate that!

Adds properties for current direction, charge and voltage alarms Signed-off-by: Philipp Steiner <[email protected]>

format fuel_gauge.h according to the clang-format settings Signed-off-by: Philipp Steiner <[email protected]>

Add driver for the Onsemi LC709203F fuel gauge Signed-off-by: Philipp Steiner <[email protected]>

Add test for the Onsemi LC709203F fuel gauge Signed-off-by: Philipp Steiner <[email protected]>

update because of LC709203F driver was added Signed-off-by: Philipp Steiner <[email protected]>

Adds missing property values for battery connect and present state Signed-off-by: Philipp Steiner <[email protected]>

Replace IC specific fuel gauge example with a generic fuel gauge example Signed-off-by: Philipp Steiner <[email protected]>

DBS06 · 2025-04-30T06:47:38Z

@teburd

@kartben @aaronemassey @teburd I have one questiong regarding the doc/hardware/peripherals/fuel_gauge.rst Imho I think this doc-file is partially outdated. Should I update it? Will the maintainers do it? I think I am already doing a lot of changes with the PR and to update this file is somehow part of the job.. If wished I could also open a new PR for this, but I think this is not necessary.

If you find missing/out of date docs then yes please send a separate PR updating them.

I added a PR for this issue #89301

DBS06 · 2025-04-30T06:50:34Z

Most of this looks really nice, please fix the commit message titles and messages, ensure format changes are separate, +1 from me on doing so

I changed the commit messages, split the commits and reordered them. So far I think/hope I did this in the way as it was intended by you.

Copilot

Pull Request Overview

This PR adds support for the Onsemi LC709203F fuel gauge by introducing a new driver along with the necessary device tree bindings, emulator support, Kconfig integration, and documentation updates.

Added new LC709203F driver source files, header, and emulator implementation.
Introduced a new device tree binding and updated board overlay files for fuel gauge selection.
Updated CMake configurations, Kconfig, and documentation to clearly differentiate between the LC709203F and the existing MAX17048.

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
samples/fuel_gauge/boards/adafruit_feather_esp32s2_B.overlay	Added LC709203F overlay with new compatible string and configuration.
include/zephyr/drivers/fuel_gauge.h	Extended fuel gauge property enum and union to include new LC709203F properties.
dts/bindings/fuel-gauge/onnn,lc709203f.yaml	Introduced DT binding YAML for the LC709203F.
drivers/fuel_gauge/lc709203f/ (all files)	Added driver source, header, emulator, Kconfig, and CMake integration for LC709203F.
drivers/fuel_gauge/Kconfig and CMakeLists.txt	Updated to integrate the new LC709203F driver.
Boards overlays and documentation files	Revised overlays and docs to clarify support for LC709203F versus MAX17048.

github-actions bot added area: Fuel Gauge area: Samples Samples labels Apr 24, 2025

github-actions bot requested review from aaronemassey, kartben, nashif and teburd April 24, 2025 06:28

github-actions bot assigned aaronemassey and teburd Apr 24, 2025

kartben requested a review from Copilot April 24, 2025 06:28

Copilot AI reviewed Apr 24, 2025

View reviewed changes

samples/fuel_gauge/lc709203f/src/main.c Outdated Show resolved Hide resolved

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch from b168287 to aedd521 Compare April 24, 2025 06:33

kartben requested changes Apr 24, 2025

View reviewed changes

dts/bindings/fuel-gauge/onnn,lc709203f.yaml Outdated Show resolved Hide resolved

samples/fuel_gauge/lc709203f/README.rst Outdated Show resolved Hide resolved

boards/adafruit/feather_esp32s2/doc/adafruit_feather_esp32s2.rst Outdated Show resolved Hide resolved

kartben reviewed Apr 24, 2025

View reviewed changes

drivers/fuel_gauge/lc709203f/emul_lc709203f.c Outdated Show resolved Hide resolved

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch 3 times, most recently from b1096dd to 7569d0a Compare April 24, 2025 12:17

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch 10 times, most recently from ddebd24 to d9af45c Compare April 29, 2025 09:57

DBS06 requested a review from kartben April 29, 2025 10:54

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch from d9af45c to 5ffc6da Compare April 29, 2025 11:11

teburd reviewed Apr 29, 2025

View reviewed changes

tests/drivers/fuel_gauge/lc709203f/CMakeLists.txt Outdated Show resolved Hide resolved

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch 2 times, most recently from fe82d2d to 6dedf2e Compare April 29, 2025 19:35

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch 2 times, most recently from 9014ef3 to 241bae7 Compare April 30, 2025 04:17

DBS06 added 4 commits April 30, 2025 06:20

drivers: fuelgauge: Add additional properties

11e8393

Adds properties for current direction, charge and voltage alarms Signed-off-by: Philipp Steiner <[email protected]>

drivers: fuelgauge: format fuel_gauge.h

5569fb2

format fuel_gauge.h according to the clang-format settings Signed-off-by: Philipp Steiner <[email protected]>

drivers: fuelgauge: Add Onsemi LC709203F driver

d858270

Add driver for the Onsemi LC709203F fuel gauge Signed-off-by: Philipp Steiner <[email protected]>

tests: fuelgauge: Add Onsemi LC709203F driver

27ddfce

Add test for the Onsemi LC709203F fuel gauge Signed-off-by: Philipp Steiner <[email protected]>

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch from 241bae7 to 5bfe438 Compare April 30, 2025 04:20

boards: adafruit: esp32s2_feather: update documentation

4439136

update because of LC709203F driver was added Signed-off-by: Philipp Steiner <[email protected]>

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch 3 times, most recently from 9f8ea2a to 3f523fe Compare April 30, 2025 04:32

DBS06 added 2 commits April 30, 2025 06:59

drivers: fuelgauge: Add missing property values

9400bf8

Adds missing property values for battery connect and present state Signed-off-by: Philipp Steiner <[email protected]>

samples: fuelgauge: unify fuel gauge sample

03c4e8a

Replace IC specific fuel gauge example with a generic fuel gauge example Signed-off-by: Philipp Steiner <[email protected]>

DBS06 force-pushed the add_LC709203F_fuel_gauge_driver branch from 3f523fe to 03c4e8a Compare April 30, 2025 05:00

DBS06 mentioned this pull request Apr 30, 2025

doc: fuel_gauge: upate api documentation #89301

Open

DBS06 requested a review from teburd April 30, 2025 06:50

kartben requested a review from Copilot May 7, 2025 21:10

Copilot AI reviewed May 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: fuelgauge: Add Onsemi LC709203F driver #89000

drivers: fuelgauge: Add Onsemi LC709203F driver #89000

DBS06 commented Apr 24, 2025

Copilot AI left a comment

kartben left a comment

kartben left a comment

DBS06 commented Apr 24, 2025 •

edited

Loading

DBS06 commented Apr 24, 2025

DBS06 commented Apr 24, 2025

DBS06 commented Apr 24, 2025 •

edited

Loading

DBS06 commented Apr 29, 2025

teburd commented Apr 29, 2025

teburd commented Apr 29, 2025 •

edited

Loading

teburd left a comment

DBS06 commented Apr 29, 2025

DBS06 commented Apr 30, 2025

DBS06 commented Apr 30, 2025

Copilot AI left a comment

drivers: fuelgauge: Add Onsemi LC709203F driver #89000

Are you sure you want to change the base?

drivers: fuelgauge: Add Onsemi LC709203F driver #89000

Conversation

DBS06 commented Apr 24, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

kartben left a comment

Choose a reason for hiding this comment

kartben left a comment

Choose a reason for hiding this comment

DBS06 commented Apr 24, 2025 • edited Loading

DBS06 commented Apr 24, 2025

DBS06 commented Apr 24, 2025

DBS06 commented Apr 24, 2025 • edited Loading

DBS06 commented Apr 29, 2025

teburd commented Apr 29, 2025

teburd commented Apr 29, 2025 • edited Loading

teburd left a comment

Choose a reason for hiding this comment

DBS06 commented Apr 29, 2025

DBS06 commented Apr 30, 2025

DBS06 commented Apr 30, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

DBS06 commented Apr 24, 2025 •

edited

Loading

DBS06 commented Apr 24, 2025 •

edited

Loading

teburd commented Apr 29, 2025 •

edited

Loading