openthread: Move OpenThread implementation from net to modules #89090
+869
−472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
canisLupus1313,
edmont,
jukkar,
kkasperczyk-no,
maciejbaczmanski,
mariuszpos,
pdgendt,
rlubos,
ssharks and
tbursztyka
|
I will add a release note and migration guide entries to this PR soon. |
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
cc18e05 to
54a60ae
Compare
pdgendt
reviewed
Apr 25, 2025
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
54a60ae to
1db166c
Compare
pdgendt
reviewed
Apr 25, 2025
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
1db166c to
6509f4e
Compare
rlubos
reviewed
Apr 28, 2025
Yeah, I'm debugging it locally to figure it out. |
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
6509f4e to
616fbde
Compare
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
2 times, most recently
from
26203f8 to
aff1452
Compare
github-actions
bot
added
area: UpdateHub
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
3 times, most recently
from
d6815ed to
133c4e4
Compare
rlubos
previously approved these changes
Apr 29, 2025
doc/releases/migration-guide-4.2.rst
Outdated
|
|
||
| * Now use: | ||
|
|
||
| * ``openthread_mutex_lock`` |
There was a problem hiding this comment.
Minor suggestion: for the new functions we could use func reference to generate links in the documentation
:c:func:`openthread_mutex_lock`
etc
There was a problem hiding this comment.
Right, I have it. All new things (structs, kconfigs, functions) are now shown as links. Deprecated functions remain as they were previously.
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
2 times, most recently
from
b61a12e to
e84fc07
Compare
Damian-Nordic
approved these changes
Apr 29, 2025
rlubos
previously approved these changes
Apr 29, 2025
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
e84fc07 to
7bd9745
Compare
|
@Damian-Nordic, I've provided all suggested changes, thanks! |
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
7bd9745 to
645dfea
Compare
rlubos
previously approved these changes
Apr 29, 2025
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
645dfea to
5de8d57
Compare
rlubos
previously approved these changes
Apr 29, 2025
Damian-Nordic
approved these changes
Apr 30, 2025
Move OpenThread-related code from zephyr/subsys/net/l2/openthread/openthread.c to zephyr/modules/openthread/platform/openthread.c. The primary goal of this refactor is to enable the use of OpenThread as an independent module, without the necessity of Zephyr's networking layer. This change is particularly beneficial for simple applications that have their own implementation of the IEEE802.15.4 driver and do not require a networking layer. These applications can now disable Zephyr's L2 and IEEE802.15.4 shim layers and directly use the OpenThread module, saving valuable kilobytes of memory. In this approach if the CONFIG_NET_L2_OPENTHREAD Kconfig option is set, Zephyr's L2 and IEEE802.15.4 layers will be used, and everything will function as before. The main difference is the Zephyr's L2 layer now uses the OpenThread module, no longer implementing it. While most of the functions in include/net/openthread.h have been deprecated, they are still available for use to maintain backwards compatibility. Signed-off-by: Arkadiusz Balys <[email protected]>
Add an entry to the release note and migration guide regarding moving the OpenThread implementation from the L2 networking layer to the OpenThread module. The migration guide note contains information about deprecated functions, explains what functions should be used instead and provides a guide for required updates in users' applications. Signed-off-by: Arkadiusz Balys <[email protected]>
An implementation should use a dedicated function to get openthread instance instead of using the private L2 data. Signed-off-by: Arkadiusz Balys <[email protected]>
Some OpenThread logs were moved from L2 to the OpenThread module, so enable logging from there to keep previous logging visibility. Signed-off-by: Arkadiusz Balys <[email protected]>
|
Discussed offline that the new |
ArekBalysNordic
force-pushed
the
openthread_separate_from_l2
branch
from
5de8d57 to
77b12cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move OpenThread-related code from
zephyr/subsys/net/l2/openthread/openthread.ctozephyr/modules/openthread/platform/openthread.c.The primary goal of this refactor is to enable the use of OpenThread as an independent module, without the necessity of Zephyr's networking layer.
This change is particularly beneficial for simple applications that have their own implementation of the IEEE802.15.4 driver and do not require a networking layer. These applications can now disable Zephyr's L2 and IEEE802.15.4 shim layers and directly use the OpenThread module, saving valuable kilobytes of memory.
In this approach, if the
CONFIG_NET_L2_OPENTHREADKconfig option is set, Zephyr's L2 and IEEE802.15.4 layers will be used, and everything will function as before. The main difference is that the Zephyr's L2 layer now uses the OpenThread module, no longer implementing it.While most of the functions in
include/net/openthread.hhave been deprecated, they are still available for use to maintain backwards compatibility.