Shell kernel cmds adaptation #9363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
requested review from
andrewboie,
andyross,
jhedberg,
jukkar,
nashif,
pfalcon,
sjanc,
tarunkum,
tbursztyka and
Vudentz
as code owners
Codecov Report
@@ Coverage Diff @@
## master #9363 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 213 213
Lines 26148 26148
Branches 5636 5636
=======================================
Hits 13749 13749
Misses 10145 10145
Partials 2254 2254Continue to review full report at Codecov.
|
Closed
nordic-krch
force-pushed
the
shell_kernel_cmds_adaptation
branch
2 times, most recently
from
1c950b6 to
25e71e7
Compare
|
@nordic-krch please rebase |
nordic-krch
force-pushed
the
shell_kernel_cmds_adaptation
branch
from
25e71e7 to
a2954a2
Compare
nordic-krch
changed the title
|
rebased, removed DNM label. |
|
I am not getting the expected command when I run this for qemu_x86 |
|
@nashif by default kernel commands are disabled in menuconfig in this example. I ran enable them by default. |
ah, no wonder. Not sure why it was disabled. Can we enable this again? |
Kernel commands ported to new shell. Signed-off-by: Krzysztof Chruscinski <[email protected]>
Enable kernel shell and adapt test data and remove limited whitelisting. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
shell_kernel_cmds_adaptation
branch
from
a2954a2 to
624a021
Compare
nashif
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains #9362 and should be merged together or after 'parent' PR.
Commands from kernel_service.c ported to new shell subsystem.
Fixes #8880