Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more SDL3 related functions #14

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Conversation

coat
Copy link
Contributor

@coat coat commented Feb 27, 2025

Adds setMainReady setAppMetadata, and renderDebugText SDL3 functions.

Copy link
Member

@hazeycode hazeycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note that per the SDL docs, SDL_SetAppMetadata and SDL_RenderDebugText can produce errors. Usually in this case we return an error set instead of a bool, see init for example. Unfortunately, it looks like there are some bindings (such as setHint) that aren't following this pattern.

@coat
Copy link
Contributor Author

coat commented Feb 28, 2025

Thanks! Note that per the SDL docs, SDL_SetAppMetadata and SDL_RenderDebugText can produce errors. Usually in this case we return an error set instead of a bool, see init for example. Unfortunately, it looks like there are some bindings (such as setHint) that aren't following this pattern.

Ahh thanks, should've read the docs closer 😅 This should be fixed now. Happy to fix up those bindings in another PR.

Copy link
Member

@hazeycode hazeycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hazeycode hazeycode merged commit 8d50206 into zig-gamedev:main Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants