add build script parameter to set ZIG_OPTIMIZE_MODE #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
Mar 24, 2025
Comment on lines
-198
to
200
| -Doptimize=ReleaseFast \ | ||
| -Doptimize="$ZIG_OPTIMIZE_MODE" \ | ||
| -Dstrip \ |
There was a problem hiding this comment.
One potential issue I see with this PR is this. I would assume that the motivation for distributing e.g. a ReleaseSafe build of the compiler is that we can get useful stack traces when something goes wrong on the user's machine. It seems like -Dstrip undermines that.
There was a problem hiding this comment.
but andrew has expressed not wanting to add branching to this script, so that leaves the open question of if the -Dstrip should be removed unconditionally and -Dopotimize changed to ReleaseSafe always and the option removed in the wake of the acceptance of 15194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 1/2 of ziglang/zig#15194
will make follow-up pr to https://github.com/ziglang/www.ziglang.org/blob/master/.github/workflows/build-tarballs.sh if/once this one is merged.