Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send patch to LLVM adding the muslabin32 target environment #2909

Closed
Tracked by #22014
andrewrk opened this issue Jul 16, 2019 · 2 comments
Closed
Tracked by #22014

Send patch to LLVM adding the muslabin32 target environment #2909

andrewrk opened this issue Jul 16, 2019 · 2 comments
Labels
arch-mips 32-bit and 64-bit MIPS backend-llvm The LLVM backend outputs an LLVM IR Module. os-linux upstream An issue with a third party project that Zig uses.
Milestone
0.15.0

Comments

@andrewrk
Copy link
Member

andrewrk commented Jul 16, 2019 •
edited
Loading

musl supports the mipsn32 ABI but LLVM only has musl, musleabi, and musleabihf.

This C ABI is therefore unavailable in Zig even though musl provides it.

This should be an uncontroversial patch that I expect LLVM to accept easily.

https://github.com/llvm/llvm-project/blob/c23619b0c90056f9bd63f9b5d79caf5bf63618e8/llvm/include/llvm/ADT/Triple.h#L209-L211
@andrewrk andrewrk added contributor friendly This issue is limited in scope and/or knowledge of Zig internals. os-linux upstream An issue with a third party project that Zig uses. labels Jul 16, 2019
@andrewrk andrewrk added this to the 0.6.0 milestone Jul 16, 2019
@andrewrk andrewrk changed the title LLVM is missing the muslabin32 target Send patch to LLVM adding the muslabin32 target environment Jul 16, 2019
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Feb 10, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 30, 2020
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 Jun 4, 2021
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 Nov 24, 2021
@andrewrk andrewrk modified the milestones: 0.10.0, 0.11.0 Apr 16, 2022
@andrewrk andrewrk modified the milestones: 0.11.0, 0.12.0 Apr 9, 2023
@alexrp
Copy link
Member

alexrp commented Sep 5, 2024

Doing this now, and will also add muslabi64 while I'm here. (muslx32 has also been added in the meantime since this issue was opened.)

@alexrp
Copy link
Member

alexrp commented Sep 7, 2024

llvm/llvm-project#107664

@alexrp alexrp mentioned this issue Oct 16, 2024
Open
7 tasks
@alexrp alexrp self-assigned this Oct 16, 2024
@alexrp alexrp added backend-llvm The LLVM backend outputs an LLVM IR Module. arch-mips 32-bit and 64-bit MIPS labels Nov 3, 2024
@alexrp alexrp removed the contributor friendly This issue is limited in scope and/or knowledge of Zig internals. label Nov 19, 2024
@alexrp alexrp mentioned this issue Mar 15, 2025
Closed
14 tasks
alexrp added a commit that referenced this issue Mar 18, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
cd0eb77 
Closes #2909.
alexrp added a commit that referenced this issue Mar 21, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
82839ff 
Closes #2909.
alexrp added a commit that referenced this issue Mar 24, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
073167e 
Closes #2909.
alexrp added a commit that referenced this issue Apr 2, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
e333cc9 
Closes #2909.
alexrp added a commit that referenced this issue Apr 3, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
2c36e4d 
Closes #2909.
alexrp added a commit that referenced this issue Apr 3, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
475a896 
Closes #2909.
alexrp added a commit that referenced this issue Apr 3, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
408b194 
Closes #2909.
alexrp added a commit that referenced this issue Apr 3, 2025
@alexrp
llvm: Use muslabin32/muslabi64 environments in the target triple.
8b2a41d 
Closes #2909.
@alexrp alexrp removed their assignment Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-mips 32-bit and 64-bit MIPS backend-llvm The LLVM backend outputs an LLVM IR Module. os-linux upstream An issue with a third party project that Zig uses.
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@alexrp @andrewrk