std.os.linux: add constants for ETH #23460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered putting a P struct inside the ETH struct? This would allow accessing as ETH.P.ALL |
kj4tmp
approved these changes
Apr 4, 2025
|
@dacheng-gao there is no need to rebase, you can leave it to zig team to handle the rest once your tests have passed. It is a waste of test resources. (I am not part of the zig team) |
|
@kj4tmp good to know that. Thank you. |
alexrp
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETH definitions https://github.com/torvalds/linux/blob/master/include/uapi/linux/if_ether.h
This closes #23428 .