Skip to content

Compilation: add missing link file options to cache manifest #23921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlugg
Copy link
Member

@mlugg mlugg commented May 18, 2025

I unintentionally closed #23891 while pruning branches; this is the exact same diff.

Resolves: #23869

@mlugg mlugg requested a review from andrewrk May 18, 2025 20:15
Copy link
Member

@alexrp alexrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not Andrew but FWIW this looks fine to me.

@mlugg
Copy link
Member Author

mlugg commented May 29, 2025

I'll take that, I certainly don't think it can cause any issues. I'll try and double check that it actually fixes the issue (I barely tested this locally lol) and merge if all is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential cache issue leading to inconsistent
2 participants