Skip to content

Version number for 1.7.0 is not updated #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pamiel opened this issue Oct 19, 2018 · 5 comments
Closed

Version number for 1.7.0 is not updated #212

pamiel opened this issue Oct 19, 2018 · 5 comments

Comments

@pamiel
Copy link
Contributor

pamiel commented Oct 19, 2018

Just to let you know that the version number here https://github.com/zmartzone/lua-resty-openidc/blob/v1.7.0/lib/resty/openidc.lua#L75 has not been updated and is still set to "1.6.1".

@zandbelt
Copy link
Contributor

darn, could have sworn...

zandbelt added a commit that referenced this issue Oct 19, 2018
@pamiel
Copy link
Contributor Author

pamiel commented Oct 19, 2018

Sorry, one extra small thing:
Release note https://github.com/zmartzone/lua-resty-openidc/releases/tag/v1.7.0 says that

Note that opts.secret and opts.redirect_uri are now deprecated and will be removed in the next release; a warning is issued in the log now.

But indeed this is redirect_uri_path that is deprecated and not redirect_uri (as correctly said a couple of lines after)

@zandbelt
Copy link
Contributor

corrected, thanks again!

@vishnu2kmohan
Copy link
Contributor

@zandbelt I don't see the 1.7.0 release up on opm.openresty.org yet?

@zandbelt
Copy link
Contributor

also done now, thanks for the last time... (I hope)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants