Skip to content

Adding functions to invalidate the various caches #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

pamiel
Copy link
Contributor

@pamiel pamiel commented Feb 7, 2018

A time to live in the server caches for the data retrieved from Discovery and JWKS endpoints is defined (1day). This is good as it enables implementing some specific use cases such as key rotation.

However, it might be required to invalidate the caches immediately, in order an update of the OP to be taken into account immediately, for example.

This PR provide the functions (one internal, and one external) to enable a lua-resty-openidc client code to trigger the caches invalidation. Discovery and JWKS, caches are flushed, but also introspection as it is better to re-evaluate tokens as the jwks and discovery data may have changed.

@zandbelt
Copy link
Contributor

zandbelt commented Feb 8, 2018

Could you please add something to the ChangeLog as well? Thanks.

@pamiel
Copy link
Contributor Author

pamiel commented Feb 8, 2018

Sure. Pushed.

@pamiel
Copy link
Contributor Author

pamiel commented Feb 13, 2018

Hi,
Any missing info and blocking point that prevents from accepting the PR ?

@bodewig
Copy link
Collaborator

bodewig commented Feb 13, 2018

no, everything is fine, sorry for the delay

@bodewig bodewig merged commit 6423b8f into zmartzone:master Feb 13, 2018
@pamiel
Copy link
Contributor Author

pamiel commented Feb 14, 2018

No problem; I thought I forgot to do something !
Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants