Skip to content

create a new session id when the token has been refreshed #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2018
Merged

create a new session id when the token has been refreshed #209

merged 2 commits into from
Oct 16, 2018

Conversation

bodewig
Copy link
Collaborator

@bodewig bodewig commented Oct 13, 2018 •
edited
Loading

seems to fix #190

@bodewig bodewig mentioned this pull request Oct 13, 2018
Closed
@bodewig bodewig requested a review from zandbelt October 16, 2018 10:05
zandbelt
zandbelt approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@zandbelt zandbelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested myself but I believe this was done elsewhere

@bodewig bodewig merged commit e131b08 into master Oct 16, 2018
@bodewig bodewig deleted the create_new_session_on_refresh branch October 18, 2018 15:49
@eriksunsol eriksunsol mentioned this pull request May 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zandbelt zandbelt zandbelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition when refreshing access tokens in a web app + API scenario
2 participants
@bodewig @zandbelt