Skip to content

highlight unclosed string literals #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
euclio opened this issue Mar 10, 2016 · 2 comments
Closed

highlight unclosed string literals #277

euclio opened this issue Mar 10, 2016 · 2 comments
Labels
Improvement

Comments

@euclio
Copy link

euclio commented Mar 10, 2016

I'm trying to switch over to zsh from fish, and I really miss how fish's syntax highlighting will highlight unclosed string literals as red. I couldn't figure out how to do this with the current plugin.
@danielshahaf
Copy link
Member

It's not currently possible: the code looks for the starting quote and doesn't distinguish whether or not a final quote is present. (This gives rise to #130.)

As a workaround, you might try to revert ff4d402, which would cause unterminated strings not to be highlighted.

Possibly related is workers/37631 about detecting unterminated words.

@phy1729
Copy link
Member

phy1729 commented Nov 16, 2017

This could be implemented after #454 is merged.

phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Nov 16, 2017
@phy1729
main: Introduce *-quoted-argument-unclosed styles
61d6776 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Nov 16, 2017
@phy1729
main: Introduce *-quoted-argument-unclosed styles
ce2bd81 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Nov 24, 2017
@phy1729
main: Introduce *-quoted-argument-unclosed styles
4107446 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Dec 20, 2017
@phy1729
main: Introduce *-quoted-argument-unclosed styles
08e7b3c 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Dec 23, 2017
@phy1729
main: Introduce *-quoted-argument-unclosed styles
19ca7b7 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Dec 24, 2017
@phy1729
main: Introduce *-quoted-argument-unclosed styles
b0ccb9f 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Dec 24, 2017
@phy1729
main: Introduce *-quoted-argument-unclosed styles
e225a33 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Dec 24, 2017
@phy1729
main: Add *-quoted-argument-unclosed styles
f027247 
Closes zsh-users#277.
@phy1729 phy1729 mentioned this issue Dec 24, 2017
Merged
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Dec 24, 2017
@phy1729
main: Add *-quoted-argument-unclosed styles
dd15e13 
Closes zsh-users#277.
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Dec 24, 2017
@phy1729
main: Add *-quoted-argument-unclosed styles
bdbe214 
Closes zsh-users#277.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phy1729 @euclio @danielshahaf