-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Highlight parameter expansion history modifiers #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Modifiers require braces when KSH_ARRAYS is set. |
According to zshexpn, modifiers are:
|
@phy1729 You mentioned having some pending changes to this area of the code, please unassign yourself once they've been merged to master (to avoid needless conflicts). Thanks! |
I've implemented something that covers the modifiers that take no argument: master...danielshahaf:i485-history-modifiers-v1 ... but if I wrote a regression test, it would conflict with #492, so instead I just described the regression test I would create (pending manual verification, of course) and I'll put this on hold pending #492's merge. |
I think that bit and the parameter handling in _highlight_arguments should be pulled out into a new function. Not sure what to do about the style. Perhaps |
|
Triage: #697 (comment) |
$foo:hey
should highlight$foo:h
as a parameter expansion.$foo:h:h:t
The text was updated successfully, but these errors were encountered: