Skip to content

Empty command check false positives #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danielshahaf opened this issue Jun 16, 2019 · 2 comments
Closed

Empty command check false positives #616

danielshahaf opened this issue Jun 16, 2019 · 2 comments
Labels
Bug syntax:command-word

Comments

@danielshahaf
Copy link
Member

The code that highlights the second ; in foo; ; bar as an error also fires for :; followed by newline. Found by @phy1729.
danielshahaf added a commit that referenced this issue Jun 16, 2019
@danielshahaf
'main': Add an XFail regression test for issue #616.
d766243
@danielshahaf danielshahaf mentioned this issue Jun 16, 2019
Merged
@danielshahaf
Copy link
Member Author

The relation to #568 is through the newline that follows the comment in the alias-comment1 test file:

zsh-syntax-highlighting/highlighters/main/test-data/alias-comment1.zsh

Line 32 in d766243

alias x=$'# foo\npwd'

@danielshahaf
Copy link
Member Author

The XFail test is XPASSing: #623.

@danielshahaf danielshahaf mentioned this issue Jul 7, 2019
Closed
danielshahaf added a commit that referenced this issue Jul 7, 2019
@danielshahaf
'main': Hackily unbreak 'make test'.
ab4b6f5 
The test point is XPASSing, which makes CI red.  As a duct tape measure to turn
CI green again, update the test expectations to make it XFAIL.  The hacky part
is that the expectation set by this commit will never be met; the test point
will never XPASS now until its expectations are changed again.

Issue #623 remains open to track setting the test expectation to the correct
value (i.e., make the test XFAIL in a manner that _will_ XPASS if the bug is
fixed; in other words, pay off the technical debt created by this commit).

Issue #616 remains open to fix the actual bug.
danielshahaf added a commit that referenced this issue Jul 21, 2019
@danielshahaf
'main': Fix issue #623 by fixing the expectations of the regression t…
8e78e9d 
…est of issue #616.
@danielshahaf danielshahaf mentioned this issue Mar 15, 2020
Closed
danielshahaf added a commit that referenced this issue Mar 15, 2020
@danielshahaf
tests: Distinguish issues #616 and #677.
e94dc89 
See #677 (comment) for details.

(In particular, there's already another test that calls itself #616.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug syntax:command-word
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielshahaf