Command position: non-executable files, non-cdable directories, CDPATH false positives #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2020
|
Also adds AUTO_CD support. |
danielshahaf
commented
Jan 25, 2020
danielshahaf
commented
Mar 15, 2020
danielshahaf
added a commit
that referenced
this pull request
Mar 16, 2020
* commit 'b1f36d9c5f45b879fbd2f64195167a60d9f3cb9e': 'main': Add a comment. 'main': Fix the $CDPATH from the previous commit. 'main': Add a test for a $CDPATH bug.
danielshahaf
force-pushed
the
cdpath-and-nonexecutable-in-command-position-v1
branch
from
630b416 to
dee05a7
Compare
|
Rebased to current master and rewritten a few bits that weren't ready for prime time. |
danielshahaf
force-pushed
the
cdpath-and-nonexecutable-in-command-position-v1
branch
2 times, most recently
from
6323686 to
41974a3
Compare
|
Rebased to solve a conflict with fb69f4c. |
The next commits will change this behaviour.
…O_CD is set) and non-executable files. Fixes zsh-users#202. Test expectations are updated. For example, BUFFER='/bin' is now highlighted as path_prefix because it's a prefix of '/bin/sh' which would be valid. However, BUFFER='/bin;' is now properly highlighted as an error (unless AUTO_CD is set).
danielshahaf
force-pushed
the
cdpath-and-nonexecutable-in-command-position-v1
branch
from
41974a3 to
f2726d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a CDPATH bug and #202. Also handles the case of non-executable directories.