Skip to content

msglist: Update icon of "Mark all messages as read" button #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Feb 15, 2025 · 5 comments · Fixed by #1274
Closed

msglist: Update icon of "Mark all messages as read" button #1357

chrisbobbe opened this issue Feb 15, 2025 · 5 comments · Fixed by #1274
Labels
a-msglist The message-list screen, except what's label:a-content
Milestone
M5b: Launch goals

Comments

@chrisbobbe
Copy link
Collaborator

We've decided to change the icon for the "Mark all messages as read" button at the bottom of the message list. Here's what it looks like now:

Image

It should instead match what we use in web:

Image

The source should be this SVG in Figma.

Discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/mark-as-read.20icon/near/2092108
@chrisbobbe chrisbobbe added the a-msglist The message-list screen, except what's label:a-content label Feb 15, 2025
@chrisbobbe chrisbobbe added this to the M5: Launch milestone Feb 15, 2025
@chrisbobbe chrisbobbe mentioned this issue Feb 15, 2025
Merged
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 15, 2025
@lakshya1goel
msglist: Update "Mark all messages as read" button icon
4e3736f 
Fixes: zulip#1357
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 20, 2025
@lakshya1goel
msglist: Update "Mark all messages as read" button icon
181dc8c 
Fixes: zulip#1357
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 20, 2025
@lakshya1goel
msglist: Update "Mark all messages as read" button icon
d4718ff 
Icon taken from the Figma design:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile\?node-id\=3512-7\&t\=FEydAZe5DNKVlKnV-0
Fixes: zulip#1357
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 20, 2025
@lakshya1goel
msglist: Update "Mark all messages as read" button icon
b8d36af 
Icon taken from the Figma design:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=FEydAZe5DNKVlKnV-0

Fixes: zulip#1357
@tomlin7 tomlin7 mentioned this issue Feb 21, 2025
Closed
@ashwanisng

This comment has been minimized.

Sign in to view
gnprice pushed a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 4, 2025
@lakshya1goel @gnprice
msglist: Update "Mark all messages as read" button icon
3eba8b1 
Icon taken from the Figma design:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=FEydAZe5DNKVlKnV-0

Fixes: zulip#1357
@chrisbobbe
Copy link
Collaborator Author

This is being fixed in #1274.

chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Mar 4, 2025
@chimnayajith
msglist: Update "Mark all messages as read" icon
9e7a237 
Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=FEydAZe5DNKVlKnV-0

Fixes: zulip#1357
chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Mar 4, 2025
@chimnayajith
msglist: Update "Mark all messages as read" icon
1021c36 
Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=FEydAZe5DNKVlKnV-0

Fixes: zulip#1357
chimnayajith added a commit to chimnayajith/zulip-flutter that referenced this issue Mar 6, 2025
@chimnayajith
msglist: Update "Mark all messages as read" icon
6dfcba3 
Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=FEydAZe5DNKVlKnV-0

Fixes: zulip#1357
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Mar 8, 2025
@lakshya1goel
msglist: Update "Mark all messages as read" button icon
59524d1 
Icon taken from the Figma design:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=FEydAZe5DNKVlKnV-0

Fixes: zulip#1357
@vivekTiw120303
Copy link

Hello, I wanted to work on this issue.

@vivekTiw120303 vivekTiw120303 mentioned this issue Mar 10, 2025
Closed
@rajveermalviya

This comment has been minimized.

Sign in to view
@vivekTiw120303

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: Done
Milestone
M5b: Launch goals
4 participants
@chrisbobbe @rajveermalviya @ashwanisng @vivekTiw120303