Skip to content

Show detailed poll-failure feedback, in beta #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Mar 8, 2024 · 4 comments · Fixed by #868
Closed

Show detailed poll-failure feedback, in beta #555

gnprice opened this issue Mar 8, 2024 · 4 comments · Fixed by #868
Assignees
Labels
beta feedback Things beta users have specifically asked for

Comments

@gnprice
Copy link
Member

gnprice commented Mar 8, 2024

This is a followup to:

We seem to be sometimes failing to poll the event queue, even after #185 and #184, for reasons that aren't yet clear; see chat thread. To help us pin that down, it'd be good to show some more details to the user while it's happening. So when we hit any kind of error in polling the event queue, let's show that error to the user.

A straightforward and discoverable way to do that would be with a toast. So let's start with that.

We could also subsequently build a bit more elaborate of a system where we record the message in some kind of in-app log, and then have a screen the user can navigate to that shows the error log. We don't yet have a settings screen at all, though, so there'd be some UI work to do to even have a place to put that screen (in addition to building the log UI itself).

@PIG208
Copy link
Member

PIG208 commented Aug 5, 2024

I think detailed poll-failure feedback is valuable for unforeseen errors. Going ahead with the linear indicator for #465, most common transient errors (unless they persist) do not need a toast. This will help with the noise issue if we only show a toast for all kinds of poll-failure.

@PIG208
Copy link
Member

PIG208 commented Aug 5, 2024

Because our compose box is a part of the body on the Scaffold, Flutter's SnackBar does not know to avoid blocking it. Normally if there is a bottomNavigationBar (e.g. in light box pages) or a floating action button, the snack bar could float above and even animate y offset change when navigating between different pages.

An option might be moving the compose box to bottomNavigationBar, but we will need to find a fix to address the MediaQuery change when the keyboard is shown. There are also options like making a placeholder bottomNavigationBar or creating a custom SnackBar. Will need to experiment a bit to see if any of them is feasible. There could be some easier alternatives that I'm not aware of.

@PIG208
Copy link
Member

PIG208 commented Aug 5, 2024

Because such poll-failures can be critical and rare enough that it's fine to block the compose box, it is not necessary to handle this issue if it turns out to be too much work. We can work on a simple SnackBar-based implementation for now.

@PIG208 PIG208 self-assigned this Aug 8, 2024
@gnprice
Copy link
Member Author

gnprice commented Aug 12, 2024

Yeah, rearranging the compose box or customizing SnackBar is definitely out of scope for this issue — if the notices obscure the compose box and we decide that's annoying, that's still fine for launch and any customizations like that would be a post-launch issue.

PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 12, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 16, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 16, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 16, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 21, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 21, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 22, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 22, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 22, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 22, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 22, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 23, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Aug 26, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 5, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 7, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 9, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 9, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 9, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 10, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 10, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 11, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 11, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 11, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 11, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 11, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 12, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 12, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 24, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 26, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 26, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 27, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 27, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 27, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Sep 30, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Oct 21, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Oct 21, 2024
Usually when a client goes back from sleep or lose network connection,
there will be a bunch of errors when polling event queue.  This known
error will always be a `NetworkException`, so we make a separate case
for it.

Previously, we may report these errors, and it ended up being spammy.
This filters out the more interesting one to report instead.

Fixes: zulip#555

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Oct 21, 2024
Usually when a client goes back from sleep or lose network connection,
there will be a bunch of errors when polling event queue.  This known
error will always be a `NetworkException`, so we make a separate case
for it.

Previously, we may report these errors, and it ended up being spammy.
This filters out the more interesting one to report instead.

Fixes: zulip#555

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Oct 22, 2024
Usually when a client goes back from sleep or lose network connection,
there will be a bunch of errors when polling event queue.  This known
error will always be a `NetworkException`, so we make a separate case
for it.

Previously, we may report these errors, and it ended up being spammy.
This filters out the more interesting one to report instead.

Fixes: zulip#555

Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta feedback Things beta users have specifically asked for
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants