-
Notifications
You must be signed in to change notification settings - Fork 306
Show detailed poll-failure feedback, in beta #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think detailed poll-failure feedback is valuable for unforeseen errors. Going ahead with the linear indicator for #465, most common transient errors (unless they persist) do not need a toast. This will help with the noise issue if we only show a toast for all kinds of poll-failure. |
Because our compose box is a part of the body on the Scaffold, Flutter's SnackBar does not know to avoid blocking it. Normally if there is a An option might be moving the compose box to |
Because such poll-failures can be critical and rare enough that it's fine to block the compose box, it is not necessary to handle this issue if it turns out to be too much work. We can work on a simple SnackBar-based implementation for now. |
Yeah, rearranging the compose box or customizing SnackBar is definitely out of scope for this issue — if the notices obscure the compose box and we decide that's annoying, that's still fine for launch and any customizations like that would be a post-launch issue. |
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Usually when a client goes back from sleep or lose network connection, there will be a bunch of errors when polling event queue. This known error will always be a `NetworkException`, so we make a separate case for it. Previously, we may report these errors, and it ended up being spammy. This filters out the more interesting one to report instead. Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Usually when a client goes back from sleep or lose network connection, there will be a bunch of errors when polling event queue. This known error will always be a `NetworkException`, so we make a separate case for it. Previously, we may report these errors, and it ended up being spammy. This filters out the more interesting one to report instead. Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
Usually when a client goes back from sleep or lose network connection, there will be a bunch of errors when polling event queue. This known error will always be a `NetworkException`, so we make a separate case for it. Previously, we may report these errors, and it ended up being spammy. This filters out the more interesting one to report instead. Fixes: zulip#555 Signed-off-by: Zixuan James Li <[email protected]>
This is a followup to:
We seem to be sometimes failing to poll the event queue, even after #185 and #184, for reasons that aren't yet clear; see chat thread. To help us pin that down, it'd be good to show some more details to the user while it's happening. So when we hit any kind of error in polling the event queue, let's show that error to the user.
A straightforward and discoverable way to do that would be with a toast. So let's start with that.
We could also subsequently build a bit more elaborate of a system where we record the message in some kind of in-app log, and then have a screen the user can navigate to that shows the error log. We don't yet have a settings screen at all, though, so there'd be some UI work to do to even have a place to put that screen (in addition to building the log UI itself).
The text was updated successfully, but these errors were encountered: