Skip to content

msglist: Use special background color for DM messages #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chrisbobbe opened this issue May 15, 2024 · 2 comments · May be fixed by #1305
Open

msglist: Use special background color for DM messages #681

chrisbobbe opened this issue May 15, 2024 · 2 comments · May be fixed by #1305
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content
Milestone
M6: Post-launch

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented May 15, 2024 •
edited
Loading

This is part of #157.

The web app uses a special background color for DM messages:

image

This color is currently identified as --color-background-private-message-content in web/styles/app_variables.css in zulip/zulip.

We should use this color.

We should follow the web app in also giving this background to a DM message's corresponding date separator, if any:

image
(Expand to see a screenshot from a quick attempt I made, and _forgot_ to handle the date separator. Don't do this! 🙂) image
@chrisbobbe chrisbobbe added a-msglist The message-list screen, except what's label:a-content a-design Visual and UX design labels May 15, 2024
@chrisbobbe chrisbobbe added this to the Beta 3: Summer 2024 milestone May 15, 2024
@chrisbobbe chrisbobbe mentioned this issue May 15, 2024
Closed
shlokjain2031 added a commit to shlokjain2031/zulip-flutter that referenced this issue Jul 2, 2024
@shlokjain2031
Added a method to create a special background color for DM messages
e101f71 
Passed the narrow as a parameter through the message list widgets and created a method (specialBackgroundColorForDm) to output the correct color based on the type of narrow, specifically for the DmNarrow. It solves issue zulip#681 of special background color for DM messages.
@pranay-sankar-muppanenei
Copy link

is this issue is still open,if it is please assign it to me?

i have some doubts about this issue.

in a web app there is a different background color for a message but it is not the case with the mobile apps.this is what i understood.

can you please give some clarity?

@chrisbobbe chrisbobbe mentioned this issue Jan 14, 2025
Merged
@E-m-i-n-e-n-c-e
Copy link
Contributor

Fixed it. Only had to change like 8-10 lines of code. Please assign it to me

Image

Image

Image

Image

E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 24, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
2adc3e9 
This commit modifies DmMessage and its DateSeparator to use a different background color from StreamMessage. This matches the web app's behavior where DM messages have a distinct background color.

Added new theme colors to MessageListTheme(These colors match the web app version)

* Light theme: hsl(45deg 20% 96%)

* Dark theme: hsl(46deg 7% 16%)

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 24, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
9f4fd69 
This commit modifies DmMessage and its DateSeparator to use a different background color from StreamMessage. This matches the web app's behavior where DM messages have a distinct background color.

Added new theme colors to MessageListTheme(These colors match the web app version)

* Light theme: hsl(45deg 20% 96%)

* Dark theme: hsl(46deg 7% 16%)

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 24, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
94024b4 
This commit modifies DmMessage and its DateSeparator to use a different background color from StreamMessage. This matches the web app's behavior where DM messages have a distinct background color.

Added new theme colors to MessageListTheme(These colors match the web app version)

* Light theme: hsl(45deg 20% 96%)

* Dark theme: hsl(46deg 7% 16%)

Fixes zulip#681.
@E-m-i-n-e-n-c-e E-m-i-n-e-n-c-e linked a pull request Jan 24, 2025 that will close this issue
Open
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 25, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
4b17b0c 
This commit modifies DmMessage and its DateSeparator to use a different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 25, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
951c240 
This commit modifies DmMessage and its DateSeparator to use a different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 25, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
c46117c 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 29, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
dac9a8c 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 29, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
c160864 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 30, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
9884fa6 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 30, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
41aa317 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Jan 30, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
fc226ef 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 1, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
c1264d4 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 6, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
6c415dc 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 6, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
b7fb9f9 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 6, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
31151be 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
@chrisbobbe chrisbobbe mentioned this issue Feb 7, 2025
Merged
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 21, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
3ba4bd0 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
E-m-i-n-e-n-c-e added a commit to E-m-i-n-e-n-c-e/zulip-flutter that referenced this issue Feb 26, 2025
@E-m-i-n-e-n-c-e
msglist: Use distinct background colors for DM messages.
b3bac84 
This commit modifies DmMessage and its DateSeparator to use a
different background color from StreamMessage.

Fixes zulip#681.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content
Projects
Flutter app
Status: No status
Milestone
M6: Post-launch
Development

Successfully merging a pull request may close this issue.

msglist: Use distinct background colors for DM messages. E-m-i-n-e-n-c-e/zulip-flutter
4 participants
@gnprice @chrisbobbe @pranay-sankar-muppanenei @E-m-i-n-e-n-c-e