Skip to content

Extra recipient header when topic changes case #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnprice opened this issue Jun 18, 2024 · 1 comment · Fixed by #1106
Closed

Extra recipient header when topic changes case #739

gnprice opened this issue Jun 18, 2024 · 1 comment · Fixed by #1106
Labels
a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content help wanted
Milestone
M5b: Launch goals

Comments

@gnprice
Copy link
Member

gnprice commented Jun 18, 2024 •
edited by chrisbobbe
Loading

If you visit the thread #translation > Missing string on chat.zulip.org, around this message (the first one in today's thread):
https://chat.zulip.org/#narrow/stream/58-translation/topic/Missing.20string/near/1828362

you'll find it gets its own recipient header, even in a topic narrow, even though there are previous messages. Specifically there's a recipient header "missing string" for the older messages (which are from 2021), and another one "Missing string" for that message and the ones after it.

In general Zulip topics are case-insensitive. Specifically, if you look at that conversation in Zulip web, there's just one recipient header; it reflects the older messages, so "missing string". So we should do the same.

Related issues:
@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-model Implementing our data model (PerAccountStore, etc.) labels Jun 18, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jun 18, 2024
@gnprice gnprice modified the milestones: Beta 3: Summer 2024, Launch Sep 10, 2024
@gnprice
Copy link
Member Author

gnprice commented Oct 3, 2024

We had a second report of the issue today, with a screenshot:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/Case.20sensitivity.20in.20topics/near/1954248

@gnprice gnprice mentioned this issue Oct 3, 2024
Open
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 5, 2024
@shivanshsharma13
Make topic headers case-insensitive
a474a94 
Topics in Zulip are case-insensitive. This change makes the message list's topic headers match that behavior, so messages whose topics differ only in case (like "missing string" and "Missing string") share a single header.  This brings the behavior in line with Zulip web.

### What is the change?

The change modifies the topic comparison logic in `haveSameRecipient()` to use case-insensitive comparison when determining whether to show a new recipient header.

Fixes zulip#739
@shivanshsharma13 shivanshsharma13 mentioned this issue Dec 5, 2024
Merged
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 7, 2024
@shivanshsharma13
msglist: Remove extra recipient header when topic changes case
12c7969 
This change makes the message list's topic headers case-insensitive. Messages
with topics differing only in case (e.g., "missing string" and "Missing string")
will now share a single header. This aligns the behavior with Zulip web and
ensures a consistent user experience.

Fixes zulip#739
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 11, 2024
@shivanshsharma13
msglist: Remove extra recipient header when topic changes case
f4fc7ff 
This change makes the message list's topic headers case-insensitive
Messages with topics differing only in case (e.g., "missing string"
and "Missing string") will now share a single header. This aligns
the behavior with Zulip web and ensures a consistent user experience.

Fixes: zulip#739
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 18, 2024
@shivanshsharma13
msglist: Remove extra recipient header when topic changes case
712e75f 
This change makes the message list's topic headers case-insensitive
Messages with topics differing only in case (e.g., "missing string"
and "Missing string") will now share a single header. This aligns
the behavior with Zulip web and ensures a consistent user experience.

Fixes: zulip#739
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 18, 2024
@shivanshsharma13
msglist: Remove extra recipient header when topic changes case
f2abecc 
This change makes the message list's topic headers case-insensitive
Messages with topics differing only in case (e.g., "missing string"
and "Missing string") will now share a single header. This aligns
the behavior with Zulip web and ensures a consistent user experience.

Fixes: zulip#739
@chrisbobbe chrisbobbe mentioned this issue Dec 26, 2024
Closed
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 27, 2024
@shivanshsharma13
msglist: Remove extra recipient header when topic changes case
76515ca 
This change makes the message list's topic headers case-insensitive
Messages with topics differing only in case (e.g., "missing string"
and "Missing string") will now share a single header. This aligns
the behavior with Zulip web and ensures a consistent user experience.

Fixes: zulip#739
@gnprice gnprice closed this as completed in fcbbc9d Jan 2, 2025
Gaurav-Kushwaha-1225 pushed a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this issue Jan 8, 2025
@shivanshsharma13 @Gaurav-Kushwaha-1225
msglist: Remove extra recipient header when topic changes case
a332f80 
This change makes the message list's topic headers case-insensitive
Messages with topics differing only in case (e.g., "missing string"
and "Missing string") will now share a single header. This aligns
the behavior with Zulip web and ensures a consistent user experience.

Fixes: zulip#739
Gaurav-Kushwaha-1225 pushed a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this issue Jan 8, 2025
@shivanshsharma13 @Gaurav-Kushwaha-1225
msglist: Remove extra recipient header when topic changes case
d656a81 
This change makes the message list's topic headers case-insensitive
Messages with topics differing only in case (e.g., "missing string"
and "Missing string") will now share a single header. This aligns
the behavior with Zulip web and ensures a consistent user experience.

Fixes: zulip#739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content help wanted
Projects
Flutter app
Status: Done
Milestone
M5b: Launch goals
Development

Successfully merging a pull request may close this issue.

Make topic headers case-insensitive shivanshsharma13/zulip-flutter
1 participant
@gnprice