msglist: Show sender only when needed #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make things more convenient when we add another field on these which MessageWithSender will want to consult.
Soon these will only sometimes show the sender.
chrisbobbe
approved these changes
Sep 12, 2023
| messages: List.generate(100, (i) => eg.streamMessage(id: 950 + i, sender: eg.selfUser))); | ||
| check(itemCount(tester)).equals(101); | ||
| messages: List.generate(200, (i) => eg.streamMessage(id: 950 + i, sender: eg.selfUser))); | ||
| check(itemCount(tester)).equals(201); |
There was a problem hiding this comment.
Huh, interesting: I guess when there are a lot of consecutive short messages with the same sender and recipient, we now save a lot of vertical space, so this test needs more messages to cover as much vertical space as it wants to.
There was a problem hiding this comment.
Yep, exactly. Without this change, these messages take up so little vertical space that the message list promptly decides it needs to fetch more older messages, disrupting the sequence this test was going for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #175