Skip to content

ui: Add animation support for the edited/moved marker. #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Jun 26, 2024

This is a sequel to #762 that animates the swipe gesture.

@PIG208 PIG208 linked an issue Jun 26, 2024 that may be closed by this pull request
@PIG208 PIG208 marked this pull request as ready for review June 26, 2024 17:48
@PIG208 PIG208 force-pushed the marker-ui-final branch 2 times, most recently from 18d1b48 to 0bcd67f Compare June 27, 2024 15:28
@PIG208 PIG208 force-pushed the marker-ui-final branch 5 times, most recently from ce87e37 to 8cb21ef Compare July 6, 2024 00:23
@PIG208
Copy link
Member Author

PIG208 commented Jul 6, 2024

Comparisons:
Collapsed Expanded
1000013422 1000013427
1000013420 1000013428

@PIG208 PIG208 force-pushed the marker-ui-final branch from 8cb21ef to 7c639e6 Compare July 8, 2024 17:38
@PIG208
Copy link
Member Author

PIG208 commented Jul 8, 2024

The appearances of the markers can be checked in the comparisons table above.

Incorporating @chrisbobbe 's comment, we animate the marker from the start state to the end state as follows:

margin left margin right paddings (horizontal symmetric) distance between marker text and icon
Collapsed 5px 3px 0px 0px
Expanded 13px 3px 3px 5px

where the paddings are the distances "between the left edge of the rounded-rectangle and 'Edited'" and "between the icon and the right edge of the rounded-rectangle", the margins are the distance between the rectangle to the left of the screen and to the message content, respectively.

@PIG208 PIG208 force-pushed the marker-ui-final branch 6 times, most recently from be19a7d to 640b87e Compare July 18, 2024 18:21
@PIG208
Copy link
Member Author

PIG208 commented Jul 18, 2024

Rebased since #762 has been merged. We will need to get back to this later to investigate alternatives to LayoutBuilder.

@chrisbobbe chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Jul 26, 2024
@chrisbobbe
Copy link
Collaborator

My review is next, I think, right? I've just added "maintainer review" so I don't lose track of it.

@PIG208
Copy link
Member Author

PIG208 commented Jul 26, 2024

Yeah, this is not ready for review yet, but I will let you know once it is.

@gnprice gnprice marked this pull request as draft July 26, 2024 05:59
@gnprice
Copy link
Member

gnprice commented Jul 26, 2024

Marked as draft because that makes it easier to remember (particularly when looking at a list of PRs) which PRs have become ready for review 🙂

@PIG208 PIG208 force-pushed the marker-ui-final branch from 640b87e to 468a74f Compare July 29, 2024 21:25
@PIG208 PIG208 removed the maintainer review PR ready for review by Zulip maintainers label Aug 14, 2024
@PIG208 PIG208 closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show edited/moved marker on messages
3 participants