-
Notifications
You must be signed in to change notification settings - Fork 306
ui: Add animation support for the edited/moved marker. #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18d1b48
to
0bcd67f
Compare
ce87e37
to
8cb21ef
Compare
The appearances of the markers can be checked in the comparisons table above. Incorporating @chrisbobbe 's comment, we animate the marker from the start state to the end state as follows:
where the paddings are the distances "between the left edge of the rounded-rectangle and 'Edited'" and "between the icon and the right edge of the rounded-rectangle", the margins are the distance between the rectangle to the left of the screen and to the message content, respectively. |
be19a7d
to
640b87e
Compare
Rebased since #762 has been merged. We will need to get back to this later to investigate alternatives to |
My review is next, I think, right? I've just added "maintainer review" so I don't lose track of it. |
Yeah, this is not ready for review yet, but I will let you know once it is. |
Marked as draft because that makes it easier to remember (particularly when looking at a list of PRs) which PRs have become ready for review 🙂 |
468a74f
to
211108c
Compare
This is a sequel to #762 that animates the swipe gesture.