Skip to content

Filled out repo information #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Filled out repo information #22

merged 2 commits into from
Jul 11, 2019

Conversation

tcrowe
Copy link
Contributor

@tcrowe tcrowe commented Feb 4, 2019

What does it do?

TLDR: It makes it easier for developers to find information about the repo.

Currently, if you run this:

npm docs liboneandone
# open https://github.com/temp/temp#readme

npm info liboneandone repository
# { type: 'git', url: 'git+https://github.com/temp/temp.git' }

This PR fills in the information to point those URLs at your repo and documentation.

Additionally it adds npm test script and fixes these two issues: #20 #21

How to test?

git clone -b pkg-json-tweaks https://github.com/tcrowe/oneandone-cloudserver-sdk-nodejs.git liboneandone
cd liboneandone
npm install
npm test

I'm not sure how you guys get the tests to complete but you can see if this works. Maybe there is a test server or test cloud you run it on?

@siyb @Clement134 @alibazlamit Maybe you can review?

Thank you

@tcrowe
Copy link
Contributor Author

tcrowe commented Feb 4, 2019

The license said Apache 2 so I changed that in the package json too.

You guys can let me know if something is wrong with what I submitted.

@tcrowe
Copy link
Contributor Author

tcrowe commented Feb 4, 2019

Recommended test/mocha.opts file: https://gist.github.com/tcrowe/b22a63daea19eaee69fe2bc37adee854

@Clement134
Copy link

If tests run with this new version of mocha, it looks good to me 👍

@tcrowe
Copy link
Contributor Author

tcrowe commented Apr 25, 2019

Is there any bandwidth to look at this? I'm not sure who owns it. @jhermann @Jochen-A-Fuerbacher @leonard84 @mfriedenhagen @mikey179 @mlhartme @thekid @wsdwl @xasx

People in the community are confused about this module:
pkgcloud/pkgcloud#644

This PR will help!

@jhermann
Copy link
Member

As in a wiki , the truth can be found in the (commit) history. Most other people are just the org admins, and auto-added to each new repo

@ScriptSmith
Copy link

@tcrowe Is it worth publishing a package based on your fork, and then submitting a PR to pkgcloud to use it instead? It's frustrating for this to still be an issue.

@tcrowe
Copy link
Contributor Author

tcrowe commented Jul 11, 2019

Ideally we can get 1and1/IONOS to maintain the module but as you saw above there was no interest from the company yet.

npm owner ls liboneandone --registry=https://registry.npmjs.com
# alibazlamit <[email protected]>
# oneandone <[email protected]>

Maybe if we make enough noise they'll take notice. I am periodically using this module with IONOS service. Maybe there is a re-brand so 1and1 become IONOS? I'm not sure who to talk to.

@tcrowe
Copy link
Contributor Author

tcrowe commented Jul 11, 2019

I've asked an associate of mine to also forward the link to support. Maybe they can reach the appropriate developers.

@ScriptSmith
Copy link

ScriptSmith commented Jul 11, 2019

Yes, I was hoping to contact someone who could approve the changes. I emailed [email protected] a few days ago and explained the situation in an attempt to get them to approve the merge, but haven't heard anything back.

@ScriptSmith
Copy link

And yes, I agree that the IONOS / 1and1 / 1und1 branding is very confusing. The org still looks quite active, but the email they list at http://1and1.github.io/ just bounces.

@arepositories arepositories merged commit 94f1a05 into 1and1:master Jul 11, 2019
@mfriedenhagen
Copy link
Member

Maybe if we make enough noise they'll take notice. I am periodically using this module with IONOS service. Maybe there is a re-brand so 1and1 become IONOS? I'm not sure who to talk to.

The 1and1 group has three divisions (+-Hosting, Telecommunications, i.e. DSL&Mobile and classic Mail/Portal-provider) and the hosting division's new name is IONOS.

@ScriptSmith
Copy link

🎉 Thanks @ifernandez89

@ScriptSmith
Copy link

Is it possible to publish a new version on NPM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants