Skip to content

fix: Types of small integer constants should always set a current type #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix: Types of small integer constants should always set a current type #2132

merged 1 commit into from
Nov 11, 2021

Conversation

MaxGraey
Copy link
Member

This PR solved non-deterministic behaviour for small integer constants which was revealed here in last sample.

Thanks @dcodeIO for tremendous help in solving this problem

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey merged commit 1cbe393 into AssemblyScript:main Nov 11, 2021
@MaxGraey MaxGraey deleted the fix-unsound-cons-overflow branch November 11, 2021 09:34
@MaxGraey MaxGraey mentioned this pull request Nov 11, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO