Skip to content

fix: Fix boolean oveflow casts for constants #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix: Fix boolean oveflow casts for constants #2134

merged 1 commit into from
Nov 11, 2021

Conversation

MaxGraey
Copy link
Member

Anther part of #2132

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO November 11, 2021 12:01
dcodeIO
dcodeIO approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@MaxGraey MaxGraey merged commit 6a3e848 into AssemblyScript:main Nov 11, 2021
@MaxGraey MaxGraey deleted the fix-boolean-const-cast branch November 11, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO