feat: Add more document methods for bindings/dom.ts #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
changed the title
trusktr
reviewed
Jul 25, 2022
| @@ -115,6 +115,23 @@ export declare namespace String { | |||
| export function fromCodePoints(codepoints: i32[]): externref; | |||
| } | |||
|
|
|||
| export declare namespace Object { | |||
There was a problem hiding this comment.
These bindings only get us so far. We can't do anything with externref results directly in AssemblyScript code. For example, we can't write
const el = document.createElement('div')
el.setAttribute('foo', 'bar')
document.body.append(el)
document.body.lastElementChild === el //trueFor this reason, we can't simply say that the loader API is obsolete. Loader API is needed in order to make realistic portable code that compiles to JS (without bindings) or WebAssembly (with bindings).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be a minimal set for some meaningful DOM manipulations