-
-
Notifications
You must be signed in to change notification settings - Fork 670
feat: Add more document methods for bindings/dom.ts #2336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
af0acd2
add more document methods for bindings/dom
MaxGraey 74e7e1e
add createElement
MaxGraey ad27b1e
refactor comments
MaxGraey 7cec308
remove "| null"s
MaxGraey dfcbd12
Merge branch 'main' into more-dom-bindings
MaxGraey f5c8520
add Object.is binding
MaxGraey 2135107
add more Object methods
MaxGraey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These bindings only get us so far. We can't do anything with
externref
results directly in AssemblyScript code. For example, we can't writeFor this reason, we can't simply say that the loader API is obsolete. Loader API is needed in order to make realistic portable code that compiles to JS (without bindings) or WebAssembly (with bindings).