Fix for NPE when connection is reset by peer #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachid-o
force-pushed
the
bugfix/1769-NPE-connection-reset
branch
from
0da63b5 to
15a6f92
Compare
rachid-o
force-pushed
the
bugfix/1769-NPE-connection-reset
branch
from
15a6f92 to
37adafe
Compare
…thub Also the duration of running the build in Github varies
|
Hi, thanks for the fix ! any idea of when this can be merged ? I've also had instances where this error came up |
|
@TomGranot is there anything I can do to help to get this fix merged? |
|
@yazgoo @rachidbm Merged. Sorry for the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the NullPointerException problem reported in #1769
It looks like the NPE is introduced as programming error. because there is a null check on
channel, but in the body it usesfuture.channel()which potential returns null.I ca't oversee the impact of this change, but all tests pass when running
mvn clean verifyon my machine.