Skip to content

Fix for NPE when connection is reset by peer #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ private void scheduleReadTimeout(NettyResponseFuture<?> nettyResponseFuture) {
public void abort(Channel channel, NettyResponseFuture<?> future, Throwable t) {

if (channel != null) {
Object attribute = Channels.getAttribute(future.channel());
Object attribute = Channels.getAttribute(channel);
if (attribute instanceof StreamedResponsePublisher) {
((StreamedResponsePublisher) attribute).setError(t);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
package org.asynchttpclient.netty;

import org.asynchttpclient.DefaultAsyncHttpClient;
import org.asynchttpclient.DefaultAsyncHttpClientConfig;
import org.asynchttpclient.RequestBuilder;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;

import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.net.ServerSocket;
import java.net.Socket;
import java.net.SocketException;
import java.util.Arrays;
import java.util.concurrent.Exchanger;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeoutException;
import java.util.function.Consumer;

import static org.hamcrest.CoreMatchers.instanceOf;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.not;
import static org.testng.Assert.assertTrue;

public class NettyConnectionResetByPeerTest {

private String resettingServerAddress;

@BeforeTest
public void setUp() {
resettingServerAddress = createResettingServer();
}

@Test
public void testAsyncHttpClientConnectionResetByPeer() throws InterruptedException {
try {
DefaultAsyncHttpClientConfig config = new DefaultAsyncHttpClientConfig.Builder()
.setRequestTimeout(1500)
.build();
new DefaultAsyncHttpClient(config).executeRequest(
new RequestBuilder("GET").setUrl(resettingServerAddress)
)
.get();
} catch (ExecutionException e) {
Throwable ex = e.getCause();
assertThat(ex, is(instanceOf(IOException.class)));
}
}

private static String createResettingServer() {
return createServer(sock -> {
try (Socket socket = sock) {
socket.setSoLinger(true, 0);
InputStream inputStream = socket.getInputStream();
//to not eliminate read
OutputStream os = new OutputStream() {
@Override
public void write(int b) {
// Do nothing
}
};
os.write(startRead(inputStream));
} catch (IOException e) {
throw new RuntimeException(e);
}
});
}

private static String createServer(Consumer<Socket> handler) {
Exchanger<Integer> portHolder = new Exchanger<>();
Thread t = new Thread(() -> {
try (ServerSocket ss = new ServerSocket(0)) {
portHolder.exchange(ss.getLocalPort());
while (true) {
handler.accept(ss.accept());
}
} catch (Exception e) {
if (e instanceof InterruptedException) {
Thread.currentThread()
.interrupt();
}
throw new RuntimeException(e);
}
});
t.setDaemon(true);
t.start();
return tryGetAddress(portHolder);
}

private static String tryGetAddress(Exchanger<Integer> portHolder) {
try {
return "http://localhost:" + portHolder.exchange(0);
} catch (InterruptedException e) {
Thread.currentThread()
.interrupt();
throw new RuntimeException(e);
}
}

private static byte[] startRead(InputStream inputStream) throws IOException {
byte[] buffer = new byte[4];
int length = inputStream.read(buffer);
return Arrays.copyOf(buffer, length);
}

}