update imports to import from corehttp when generating with --unbranding=true
#2175
Labels
unbranding
Effort to also generate non-Azure SDKs
Uh oh!
There was an error while loading. Please reload this page.
We want to update all of the imports for an unbranded SDK to import from corehttp instead of from
azure.core
. The cleanest way to do this will be just updating the import type inautorest.codegen.models.imports.py
. Here, if we are unbranded, and we see an import forazure.core
, we just change it to an import fromcorehttp
. The names (besidesAzureKeyCredential
) are all the same, so this should automatically work once we update the imports serializerI believe the only caveat to this is we have changed the name of
AzureKeyCredential
toServiceKeyCredential
in gencore. Therefore, we should update ourautorest.codegen.models.AzureKeyCredentialType
andautorest.codegen.models.AzureKeyCredentialPolicyType
to be calledautorest.codegen.models.KeyCredentialType
andautorest.codegen.models.KeyCredentialPolicyType
, and have a propertyself.name
on it, which will beServiceKeyCredential
if--unbranding==true
, otherwise,ServiceKeyCredential
.The text was updated successfully, but these errors were encountered: