[non-Azure] adjust test framework to prepare for unbranded test
#2209
Conversation
| local_specification_folder = Path(f"test/{generated_sub_folder}/specification") | ||
| specification_dirs = ( | ||
| [CADL_RANCH_DIR, local_specification_folder] | ||
| if local_specification_folder.exists() |
There was a problem hiding this comment.
our logic is getting too gross with generating mgmt sphere. I think we should treat mgmt sphere like we treat storage from swagger: after we merge a PR we should regenerate with mgmt sphere tsp, so we make sure we don't break it on release. Then we can get rid of the whole local specification folder. I'm good to do these in tangent with each other.
I also think we should specifically have two functions: regenerate_azure and regenerate_unbranded, we shouldn't abstract this away. Then regenerate will just have two lines: one for calling each one. The reasons are because we expect these two to be the only ones, and this way, we can also call inv regenerate-azure or inv regenerate-unbranded from the command line, which provides good support
There was a problem hiding this comment.
(1) Agree that we shall generate from swagger repo directly. Let me do it later.
(2) Will create 2 functionsregenerate_azure and regenerate_unbranded
msyyc
changed the title
unbranded testunbranded test
|
The PR is too big to maintain, so I want to merge it ASAP. And I will make other PR to continue the unbranding work. |
fixes #2175