Skip to content

[Core] Create generic azure-core package: corehttp #32191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Sep 22, 2023

WIP

Current APIView: https://apiview.dev/Assemblies/Review/841eb4e594b04274bf21d9a42a738348

Can be installed by adding "corehttp @ git+https://github.com/Azure/azure-sdk-for-python.git@feature/generic-core#subdirectory=sdk/core/corehttp" to setup.py install_requires list.

@pvaneck pvaneck force-pushed the feature/generic-core branch from 9bf619b to fe19ef3 Compare September 25, 2023 22:35
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core

@pvaneck pvaneck force-pushed the feature/generic-core branch from 24fdede to 2e37869 Compare October 10, 2023 04:12
@pvaneck pvaneck force-pushed the feature/generic-core branch from 600f740 to 9b839a1 Compare October 14, 2023 01:26
@pvaneck pvaneck changed the title [Draft][Core] Create generic azure-core package [Draft][Core] Create generic azure-core package: corehttp Oct 18, 2023
This adds a new package called corehttp into the
"sdk/core" directory. This provides the building blocks
used when generating Python SDKs.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the feature/generic-core branch from 4f34d71 to 923dae8 Compare October 18, 2023 23:00
@lmazuel lmazuel marked this pull request as ready for review October 18, 2023 23:10
Signed-off-by: Paul Van Eck <[email protected]>
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for a preview

@pvaneck pvaneck changed the title [Draft][Core] Create generic azure-core package: corehttp [Core] Create generic azure-core package: corehttp Oct 18, 2023
@pvaneck
Copy link
Member Author

pvaneck commented Oct 19, 2023

/check-enforcer override

@pvaneck pvaneck merged commit 96098b8 into main Oct 19, 2023
@pvaneck pvaneck deleted the feature/generic-core branch October 19, 2023 01:42
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Oct 19, 2023
…into update_package_json

* 'main' of https://github.com/Azure/azure-sdk-for-python: (136 commits)
  Re-record (Azure#32584)
  Update CODEOWNERS (Azure#32583)
  capture request data with aiohttp multipart/form-data (Azure#32543)
  [Core] Create generic azure-core package: `corehttp` (Azure#32191)
  overwrite .amlignore file (Azure#32546)
  Fix Sphinx error in core (Azure#32417)
  skip pyright for now (Azure#32569)
  Fix identity-broker sdist (Azure#32568)
  Updates to interactions with `pyproject.toml` (Azure#32480)
  fix: fixing local variable's name(last_modified_exising -> last_modified_existing) typo via Cspell (Azure#32556)
  Update feature store related entities to use the GA version (Azure#32541)
  Removing unused RST files (Azure#32547)
  Update python version for virtualenv issues (Azure#32528)
  [AutoRelease] t2-keyvault-2023-10-13-36681(can only be merged by SDK owner) (Azure#32478)
  [Monitor Distro] Update broken link (Azure#32505)
  Bump python stress images and addons (Azure#32554)
  Bump (Azure#32552)
  Increment package version after release of azure-cosmos (Azure#32550)
  repair aggregate report pipeline (Azure#32509)
  update readme and samples (Azure#32548)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants