[core-rest-pipeline] set init.duplex to "half" when streaming body via fetch #26890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a fetch According to WHATWG fetch spec (https://fetch.spec.whatwg.org/#fetch-method) when body is a ReadableStream object, init.duplex must be set and currently the only valid value is "half"
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
deyaaeldeen
approved these changes
Aug 21, 2023
| // init.duplex must be set when body is a ReadableStream object. | ||
| // currently "half" is the only valid value. | ||
| if (streaming) { | ||
| (requestInit as any).duplex = "half"; |
There was a problem hiding this comment.
Looks like adding that property to the type is being tracked in microsoft/TypeScript-DOM-lib-generator#1483
dgetu
pushed a commit
that referenced
this pull request
Sep 6, 2023
…a fetch (#26890) According to WHATWG fetch spec (https://fetch.spec.whatwg.org/#fetch-method) when body is a ReadableStream object, init.duplex must be set and currently the only valid value is "half". This PR sets the property when request body is a ReadableStream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to WHATWG fetch spec (https://fetch.spec.whatwg.org/#fetch-method) when body is a ReadableStream object, init.duplex must be set and currently the only valid value is "half". This PR sets the property when request body is a ReadableStream.