Skip to content

#duplex is missing from RequestInit #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
erunion opened this issue Jan 23, 2023 · 3 comments · May be fixed by #1729
Open

#duplex is missing from RequestInit #1483

erunion opened this issue Jan 23, 2023 · 3 comments · May be fixed by #1729

Comments

@erunion
Copy link

erunion commented Jan 23, 2023

The Fetch WG introduced a new duplex property to RequestInit1 back in July that undici is now abiding by when making payload requests with a ReadableStream2. They have added this new duplex property into their own RequestInit types, but as this is now a part of the core fetch specification it should be included here.

https://fetch.spec.whatwg.org/#request-class

Footnotes

  1. https://github.com/microsoft/TypeScript-DOM-lib-generator ↩

  2. https://github.com/nodejs/node/issues/46221 ↩
@nornagon nornagon mentioned this issue Mar 10, 2023
Closed
5 tasks
@Benzolio Benzolio mentioned this issue Apr 29, 2023
Closed
Benzolio added a commit to Benzolio/authey that referenced this issue Apr 29, 2023
@Benzolio
Add required duplex option to RequestInit see nodejs/node#46221 and m…
6bd52f1 
…icrosoft/TypeScript-DOM-lib-generator#1483
This was referenced Apr 29, 2023
Closed
Merged
@taotto taotto mentioned this issue May 6, 2023
Merged
@haukepribnow
Copy link

Would this really be as easy to close as only removing this line?

@deyaaeldeen deyaaeldeen mentioned this issue Aug 21, 2023
Merged
@jeremymeng jeremymeng mentioned this issue Aug 22, 2023
Open
@MartinJohns MartinJohns mentioned this issue Dec 26, 2023
Closed
1 task
thecotne added a commit to thecotne/TypeScript-DOM-lib-generator that referenced this issue May 23, 2024
@thecotne
add duplex property in RequestInit fixes microsoft#1483
d803e50
@thecotne thecotne linked a pull request May 23, 2024 that will close this issue
Open
@Bashamega
Copy link
Contributor

That is correct @haukepribnow

@Bashamega
Copy link
Contributor

The reason #1729 wasn't merged and we removed this type is that it is only supported by Blink, and in order for a type to be added, it needs to be supported by at least two major browser engines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add duplex property in RequestInit thecotne/TypeScript-DOM-lib-generator
3 participants
@erunion @haukepribnow @Bashamega