[text analytics] merging feature branch into master #11632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: Implementation for Datasources operations (#11012) rename SearchIndexClient -> SearchClient (#10964) Servicebus - Track2 - Remove timeout from Send (#11002) Fixing compute test (#11036) fixing merge error (#11039) Update Ubuntu VM Image to 18.04 (#11032) add regular endpoint in new env variable (#11031)
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: Fix pip link in azure-keyvault-secrets readme (#11056) [ServiceBus] Update for readme and sample (#11047)
…e/azure-sdk-for-python into feature/text_analytics_v3.0 * 'feature/text_analytics_v3.0' of https://github.com/Azure/azure-sdk-for-python: [text analytics] score -> confidence_score in DetectedLanguage (#11076)
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: [ServiceBus] Settle non-deferred message through receiver link (#10800) Add sync/async samples to demonstrate consuming from a number of sessions at one time. (#11001) fixed alternative document input samples (#11078)
…o character_count (#11190)
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits) add more content to index crud samples (#11443) Add a snippet to the Samples readme mirroring the core readme, guiding users to the currently mainline version of the lib if the end up on the wrong page. (#11420) 20200515 run resource live test (#11454) Release azure mgmt eventgrid (#11431) Smoke Tests use new workflow for package install (#11438) ServiceFabric 7.1 (#11451) update (#11424) Typing for appconfiguration (#11427) [form recognizer] Move `get_client` method from FormRecognizer -> FormTraining (#11423) release customvision (#11428) Enforce https in search (#11337) [Cosmos] Remove unused files (#11388) Sync eng/common directory with azure-sdk-tools repository (#11417) [form recognizer] consistency renames for FormTrainingClient (#11390) Release for azure mgmt eventhub (#11403) Network 2020 04 01 (#11405) link in to reference docs for sub-clients (#11396) Persistent caching for interactive credentials on Linux and macOS (#11319) [formrecognizer] add AAD auth support (#11275) Search docs/readme updates (#11391) ...
…e/azure-sdk-for-python into feature/text_analytics_v3.0 * 'feature/text_analytics_v3.0' of https://github.com/Azure/azure-sdk-for-python: [text analytics] Too many documents (#11155) removed grapheme_offset and grapheme_length, renamed grapheme_count to character_count (#11190) [text analytics] Add warnings (#11053) [text analytics] Fix test errors dl recognize entities (#11083) [text analytics] Add text to sentence sentiment (#11054)
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] Update ta tests (#11461) Release azure mgmt hybridkubernetes (#11483) add ci to azure-mgmt-eventhub (#11459) [Service Bus] Enable pylint and mypy (#11316) update CODEOWNERS with smoke test owners (#11404) Sync eng/common directory with azure-sdk-tools repository (#11469)
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: (28 commits) Kaihuis maps (#11574) [formrecognizer] support Copy API (#11372) Artifact Powered Docs.MS Release (#11395) Sync eng/common directory with azure-sdk-tools repository (#11562) Updated changelog (#11554) update pinned versions in autorest_req.txt (#11557) Add user authentication API to UsernamePasswordCredential (#11528) Reduce Build Matrix (#11539) Prevent Key Vault test failure due to operation timing (#11552) update tests (#11534) Datashare 2019 11 01 (#11540) Search Renames / Regen (#11342) update unit test according to the latest uamqp update (#11533) Sync eng/common directory with azure-sdk-tools repository (#11472) rename input parameters (#11518) [cosmos] readme review feedback (#11527) Update CODEOWNERS (#11516) [Core] Support multipart changesets (#10972) fix AttributeException (#11463) release-for-hanaonazure-mgmt (#11441) ...
…A resource in canary region for v3.0 (#11582)
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: Release azure mgmt containerregistry (#11460) Prepare core 1.6.0 on master (#11610) Add force parameter to SwaggerToSdk CLI (#11609) LRO continuation_token (#10801) Remove unecessary import (#11606) Fix Cleanup failing on 3.8.3 (#11607) remove DataSourceCredentials (#11605) Search synonym map (#11590) Fix copy tests (#11594) Make use_training_labels positional required (#11529) Search refactoring 2 (#11584) Search refactoring 1 (#11572)
iscai-msft
requested review from
willmtemple,
kinelski,
maririos,
rakshith91,
samvaity,
kristapratico and
mssfang
iscai-msft
commented
May 26, 2020
| @@ -1,7 +1,15 @@ | |||
| # Change Log azure-ai-textanalytics | |||
|
|
|||
| ## 1.0.0b5 (Unreleased) | |||
| ## 1.0.0b6 (2020-05-27) | |||
There was a problem hiding this comment.
This is because I erroneously released 1.0.0b5 when trying to generate the private bits (very embarrassing), so b5 is burned for python
maririos
reviewed
May 26, 2020
| @@ -128,7 +128,7 @@ def create_text_analytics_client(self, **kwargs): | |||
| def text_analytics_account(): | |||
| test_case = AzureTestCase("__init__") | |||
| rg_preparer = ResourceGroupPreparer(random_name_enabled=True, name_prefix='pycog') | |||
| text_analytics_preparer = CognitiveServicesAccountPreparer(random_name_enabled=True, name_prefix='pycog') | |||
| text_analytics_preparer = CognitiveServicesAccountPreparer(random_name_enabled=True, name_prefix='pycog', location='CentralUSEUAP') | |||
There was a problem hiding this comment.
should we change this to westus2? or is there no difference between the canary region and westus2 now?
There was a problem hiding this comment.
I just did a run with westus2 in the hopes of changing it, I saw some flakiness (see this teams link). I can still update this here soon though
kristapratico
approved these changes
May 26, 2020
maririos
approved these changes
May 26, 2020
mssfang
approved these changes
May 27, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 27, 2020
…into models_to_submodels * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] merging feature branch into master (Azure#11632) regen swagger and make list_indexes pageable (Azure#11635) Sync eng/common directory with azure-sdk-tools repository (Azure#11566) Rename to completed_on and requested_on in the CustomFormModel (Azure#11592) [formrecognizer] model_id param validation (Azure#11569) [Batch] Fix issue in latest REST API (Azure#11604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the huge PR, this is just merging the feature branch into master
I have already tagged you guys on the PRs that added the changes to the feature branch in the past. When looking at the diff, I definitely recommend looking commit by commit