Skip to content

Update CODEOWNERS #32583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

Update CODEOWNERS #32583

merged 1 commit into from
Oct 19, 2023

Conversation

kristapratico
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kristapratico kristapratico requested a review from pvaneck October 19, 2023 19:12
@kristapratico
Copy link
Member Author

@pvaneck let me know if those owners look correct to you

pvaneck
pvaneck approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kristapratico kristapratico merged commit 660dbc9 into main Oct 19, 2023
@kristapratico kristapratico deleted the kristapratico-patch-9 branch October 19, 2023 20:41
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Oct 19, 2023
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
9c53373 
…into update_package_json

* 'main' of https://github.com/Azure/azure-sdk-for-python: (136 commits)
  Re-record (Azure#32584)
  Update CODEOWNERS (Azure#32583)
  capture request data with aiohttp multipart/form-data (Azure#32543)
  [Core] Create generic azure-core package: `corehttp` (Azure#32191)
  overwrite .amlignore file (Azure#32546)
  Fix Sphinx error in core (Azure#32417)
  skip pyright for now (Azure#32569)
  Fix identity-broker sdist (Azure#32568)
  Updates to interactions with `pyproject.toml` (Azure#32480)
  fix: fixing local variable's name(last_modified_exising -> last_modified_existing) typo via Cspell (Azure#32556)
  Update feature store related entities to use the GA version (Azure#32541)
  Removing unused RST files (Azure#32547)
  Update python version for virtualenv issues (Azure#32528)
  [AutoRelease] t2-keyvault-2023-10-13-36681(can only be merged by SDK owner) (Azure#32478)
  [Monitor Distro] Update broken link (Azure#32505)
  Bump python stress images and addons (Azure#32554)
  Bump (Azure#32552)
  Increment package version after release of azure-cosmos (Azure#32550)
  repair aggregate report pipeline (Azure#32509)
  update readme and samples (Azure#32548)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvaneck pvaneck pvaneck approved these changes

@jsquire jsquire Awaiting requested review from jsquire

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapratico @pvaneck